Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddListing is missing internal _mint call? #9

Open
0xTranqui opened this issue Oct 2, 2022 · 3 comments
Open

AddListing is missing internal _mint call? #9

0xTranqui opened this issue Oct 2, 2022 · 3 comments

Comments

@0xTranqui
Copy link
Member

0xTranqui commented Oct 2, 2022 •
edited
Loading

@iainnash spent a bunch of time trouble shooting why addListing mints weren't showing up on the zora indexer and I think its just because there isn't actually a mint call happening in the _addListings function?

Looks like this is a simple fix by adding _mint to line 210 of Curator.sol? Not sure if I'm just missing something obvious...
@iainnash
Copy link
Contributor

iainnash commented Oct 2, 2022

Yep they probably got accidentally removed in a refactor

@iainnash
Copy link
Contributor

iainnash commented Oct 2, 2022

line 208 is also now redundant.

@iainnash
Copy link
Contributor

iainnash commented Oct 2, 2022

Fixed in #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iainnash @0xTranqui