Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft Neoforge? #274

Open
ImBehinYa opened this issue May 4, 2024 · 4 comments
Open

Minecraft Neoforge? #274

ImBehinYa opened this issue May 4, 2024 · 4 comments

Comments

@ImBehinYa
Copy link

Hi,
could you add Minecraft Neoforge?

https://neoforged.net/

Thanks

@BraveCake
Copy link

there are two available templates but they haven't been merged to the main branch yet
#295 compatible with 1.20.x
#297 1.21

@spusuf
Copy link
Contributor

spusuf commented Feb 4, 2025

My PR #295 and PR #317 both work with 1.21.x so not sure why youve promo'd your own and said mine isnt compatible when its right in the readme. Either way just waiting on merge.

@disconsented
Copy link

That was also about 4 months ago, not sure what a late reply achieves here apart from a bit of pot stirring.

@BraveCake
Copy link

My PR #295 and PR #317 both work with 1.21.x so not sure why youve promo'd your own and said mine isnt compatible when its right in the readme. Either way just waiting on merge.

Nope, that's not true.
Your template is incompatible with 1.21.x and obviously you haven't tested it yet.
You need at least java 21 for Minecraft 1.21.x and yours is using java 17 (Java is backward compatible so picking the highest version required is usually the most reasonable choice)
I already tested other old templates when I was migrating my server to 1.21.x and none of them worked so I made that new one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants