Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] bootstrap 4? #29

Open
joneldiablo opened this issue Mar 13, 2018 · 8 comments
Open

[question] bootstrap 4? #29

joneldiablo opened this issue Mar 13, 2018 · 8 comments

Comments

@joneldiablo
Copy link

this project is for pug and bootstrap 4 components?

@rajasegar
Copy link
Collaborator

@joneldiablo Yes this is for pug but it is not yet updated to support Bootstrap 4

@nsagot
Copy link

nsagot commented Jul 11, 2018

So, when Bootstrap 4 ?

@rajasegar
Copy link
Collaborator

To be honest @lyoko17220 I could not find time to work on it, but after looking at this thread i have made up my mind to kick start the project, will update you all asap once it is launched.
👍

@zlix12
Copy link

zlix12 commented Apr 13, 2019

@rajasegar I would be interested in helping with the pug bs4 project.

@ksaadDE
Copy link

ksaadDE commented Nov 28, 2020

I have the same "issue" here.

So it's 11/2020 and it still contains outdated Bootstrap. I tried to fix it myself, finding out that a lot of the stuff used in the snippets are already outdated, partly or fully. Sad for the hard work...

maybe a "rewrite from scratch" could be more successful instead of fixing the parts since a lot changed in BS4+

@rajasegar you wrote somewhere something about you need funding for it. What do we talk about? $100 $1000? 😄

Also I'm wondering why you are using CDNs by Google. Which isn't always good too. Maybe using the Bootstrap CDN directly and also the JQuery CDN would be a bit better.

/E: Ok, I did a mistake... it takes a bit effort to rewrite it. But it seems possible.

I will do a push req, when I'm converted a lot of the stuff to the current Bootstrap.

@rajasegar
Copy link
Collaborator

@ksaadDE Created a tracking issue for the same
#32
All the changes are pushed on to the b4 branch https://github.com/rajasegar/PUG-Bootstrap/tree/b4
Will start working on this, but it will take some time, I cannot give a timeline, wish to complete it by this end of year, so hopefully we will have v4 support next year.
And meanwhile I would also accept funding , this is my patreon page
https://www.patreon.com/rajasegar

@ksaadDE
Copy link

ksaadDE commented Dec 3, 2020

@ksaadDE Created a tracking issue for the same
#32
All the changes are pushed on to the b4 branch https://github.com/rajasegar/PUG-Bootstrap/tree/b4
Will start working on this, but it will take some time, I cannot give a timeline, wish to complete it by this end of year, so hopefully we will have v4 support next year.
And meanwhile I would also accept funding , this is my patreon page
https://www.patreon.com/rajasegar

Awesome, sounds great!

I tried to fix (at least) the navbar. The Rest seems to work, but we'll have to change the Navbar functionality. Take a look at my repo and you'll see the diff. Maybe you can change it to your preferred Style, so we will have the same functionality like before.

Just tell me how much you need over all for completing this project, I know that you have patreon, but that doesn't mean how much you're needing ;-) People are spending more when they know a) what for and b) how much is generally needed.

Currently I don't really have time to fix everything (or to write test / test it), but I think the navbar is the biggest Deal, since it's what people will mostly use and see.

Greetz

@joneldiablo
Copy link
Author

and bs5?
XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants