Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the cookie SameSite directive to Strict #401

Open
2 tasks
sandbergja opened this issue Jan 11, 2024 · 0 comments
Open
2 tasks

Set the cookie SameSite directive to Strict #401

sandbergja opened this issue Jan 11, 2024 · 0 comments

Comments

@sandbergja
Copy link
Member

sandbergja commented Jan 11, 2024

Success criteria

  • DSS's Set-Cookie response header includes "SameSite=Strict"
  • Confirm that authentication works correctly when one follows a Login via CAS option on a study with protected file content hosted on the DSS server. Ex: https://dss.princeton.edu/studies/2

Rationale

This reduces the number of scenarios in which the cookie will be sent, providing better CSRF protection and reducing the size of the Cookies header in some cases. Part of pulibrary/dacs_handbook#154

Example PR

pulibrary/orangelight#3932

Tradeoff

If a user logs into DSS, navigates to a non-Princeton Web site (e.g. Outlook), and then clicks a link from that Web site back to DSS, they will need to log in to DSS again.

Further reading

I found this from Mozilla, this from Portswigger, and this blog post from Andrew Lock to be helpful in understanding this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants