Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try enabling vite gzip/brotli compression #1405

Open
hackartisan opened this issue Oct 18, 2022 · 4 comments
Open

Try enabling vite gzip/brotli compression #1405

hackartisan opened this issue Oct 18, 2022 · 4 comments

Comments

@hackartisan
Copy link
Member

From Jonathan Rochkind:

Continuing my vite journey… I noticed that your app does NOT have gzip/brotli production turned on in it’s vite.config. https://github.com/pulibrary/dpul/blob/main/vite.config.ts
You might want to, depending on your setup. I did, for me it was a performance regression, my app was previously delivering .js and .css gzip-compressed, but stopped doing so in my switch to vite, which is a real performance issue.
Enabling vite gzip/brotli compression fixed it though. ElMassimo/vite_ruby#281

@eliotjordan
Copy link
Member

@hackartisan
Copy link
Member Author

I wonder if it would be better to enable gzip compression on the load balancer for all content?

Interesting idea. There is still a network hop from the application machine to the load balancer, though?

@tpendragon
Copy link
Contributor

Closing this ticket means trying it and seeing how it goes.

@hackartisan
Copy link
Member Author

See how it goes by watching the network tab when loading staging site before / after making this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants