Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/nonexistent_exhibit/catalog should 404 #1436

Open
honeybadger bot opened this issue Mar 7, 2023 · 2 comments
Open

/nonexistent_exhibit/catalog should 404 #1436

honeybadger bot opened this issue Mar 7, 2023 · 2 comments

Comments

@honeybadger
Copy link

honeybadger bot commented Mar 7, 2023

Backtrace

line 4 of [PROJECT_ROOT]/app/views/catalog/_default_search_form.html.erb: _app_views_catalog__default_search_form_html_erb___2394777358780764325_13358740
line 11 of [PROJECT_ROOT]/app/helpers/application_helper.rb: rescue in render_search_bar
line 8 of [PROJECT_ROOT]/app/helpers/application_helper.rb: render_search_bar

View full backtrace and more info at honeybadger.io

@sdellis
Copy link
Member

sdellis commented Mar 7, 2023

Honeybadger Error: [DPUL/production] RuntimeError: Exhibit id exists (puo), but @exhibit hasn't been loaded yet

This could be due to an old link or bookmark. Perhaps adding the ability to alias or forward old exhibit links to updated ones would help.

@eliotjordan suggests setting up the blacklight_dynamic_sitemap gem. Example in PulfaLight: https://github.com/pulibrary/pulfalight/pull/1127/files

@sdellis sdellis changed the title [DPUL/production] RuntimeError: Exhibit id exists (puo), but @exhibit hasn't been loaded yet Old exhibit links don't resolve to updated exhibits Mar 7, 2023
@hackartisan
Copy link
Member

hackartisan commented Oct 30, 2023

This is the error you get any time you type in a nonexistent exhibit with /catalog. We should have it 404 instead of 500.

the same happens when you hit the /browse path; make sure whatever we do works for that, too.

@hackartisan hackartisan changed the title Old exhibit links don't resolve to updated exhibits /nonexistent_exhibit/catalog should 404 Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants