Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "EDM rights" to "Rights" #1449

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Rename "EDM rights" to "Rights" #1449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a067f7
Rename "EDM rights" to "Rights"
m-ichelleliu Apr 20, 2023
dca0efa
Rubocop
m-ichelleliu Apr 20, 2023
0fe4cb9
Rename 'Edm rights' to 'Rights'
m-ichelleliu Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/values/manifest_metadata.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ class Value
"Memberof" => "Collections",
"Link to catalog" => "View in catalog",
"Link to finding aid" => "View in finding aid",
"Electronic locations" => "Available online"
"Electronic locations" => "Available online",
"Edm rights" => "Rights"
}.freeze

attr_reader :key, :values
Expand Down
12 changes: 6 additions & 6 deletions spec/features/accessibility_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,10 @@
readonly_title_tesim: [
title
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand All @@ -78,7 +78,7 @@
'readonly_title-sort_ssim': [
title
],
'readonly_edm-rights_ssim': [
'readonly_rights_ssim': [
rights
],
readonly_license_ssim: [
Expand Down Expand Up @@ -201,10 +201,10 @@
readonly_title_tesim: [
title
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand All @@ -225,7 +225,7 @@
'readonly_title-sort_ssim': [
title
],
'readonly_edm-rights_ssim': [
'readonly_rights_ssim': [
rights
],
readonly_license_ssim: [
Expand Down
18 changes: 9 additions & 9 deletions spec/features/browse_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
readonly_title_tesim: [
title
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand All @@ -38,7 +38,7 @@
'readonly_title-sort_ssim': [
title
],
'readonly_edm-rights_ssim': [
'readonly_rights_ssim': [
rights
],
readonly_license_ssim: [
Expand All @@ -56,10 +56,10 @@
readonly_title_tesim: [
title2
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand All @@ -80,7 +80,7 @@
'readonly_title-sort_ssim': [
title
],
'readonly_edm-rights_ssim': [
'readonly_rights_ssim': [
rights
],
readonly_license_ssim: [
Expand All @@ -98,10 +98,10 @@
readonly_title_tesim: [
title3
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand All @@ -122,7 +122,7 @@
'readonly_title-sort_ssim': [
title
],
'readonly_edm-rights_ssim': [
'readonly_rights_ssim': [
rights
],
readonly_license_ssim: [
Expand Down
6 changes: 3 additions & 3 deletions spec/features/catalog_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
readonly_title_tesim: [
title
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand All @@ -37,7 +37,7 @@
'readonly_title-sort_ssim': [
title
],
'readonly_edm-rights_ssim': [
'readonly_rights_ssim': [
rights
],
readonly_license_ssim: [
Expand Down
18 changes: 9 additions & 9 deletions spec/models/spotlight/search_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
readonly_title_tesim: [
title
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand All @@ -40,7 +40,7 @@
'readonly_title-sort_ssim': [
title
],
'readonly_edm-rights_ssim': [
'readonly_rights_ssim': [
rights
],
readonly_license_ssim: [
Expand All @@ -58,10 +58,10 @@
readonly_title_tesim: [
title2
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand All @@ -82,7 +82,7 @@
'readonly_title-sort_ssim': [
title
],
'readonly_edm-rights_ssim': [
'readonly_rights_ssim': [
rights
],
readonly_license_ssim: [
Expand All @@ -100,10 +100,10 @@
readonly_title_tesim: [
title3
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand All @@ -124,7 +124,7 @@
'readonly_title-sort_ssim': [
title
],
'readonly_edm-rights_ssim': [
'readonly_rights_ssim': [
rights
],
readonly_license_ssim: [
Expand Down
6 changes: 5 additions & 1 deletion spec/values/manifest_metadata_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@
let(:lang_code) { { "Language" => "en" } }
let(:member) { { "Memberof" => { "title" => "Member Title" } } }
let(:id_value) { { "Title" => { "@id" => "1234" } } }
let("rights") { { "Edm rights" => "Rights Text" } }
let(:date_range_value) do
{ "date_range" => [
{
"@type" => "edm:TimeSpan",
"@type" => "edm:TimeSpan", # ????
"begin" => ["1992"],
"end" => ["1993"],
"skos:prefLabel" => "approximately 1992-1993",
Expand Down Expand Up @@ -52,6 +53,9 @@
it "uses member titles" do
expect(metadata.process_values(member)).to eq("Collections" => ["Member Title"])
end
it "calls edm-rights rights" do
expect(metadata.process_values(rights)).to eq("Rights" => ["Rights Text"])
end
it "uses @id as a last resort" do
expect(metadata.process_values(id_value)).to eq("Title" => ["1234"])
end
Expand Down
16 changes: 8 additions & 8 deletions spec/views/spotlight/browse/_search_title_html.erb_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
readonly_title_tesim: [
title
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand All @@ -44,7 +44,7 @@
'readonly_title-sort_ssim': [
title
],
'readonly_edm-rights_ssim': [
'readonly_rights_ssim': [
rights
],
readonly_license_ssim: [
Expand All @@ -62,10 +62,10 @@
readonly_title_tesim: [
title2
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand All @@ -86,7 +86,7 @@
'readonly_title-sort_ssim': [
title
],
'readonly_edm-rights_ssim': [
'readonly_rights_ssim': [
rights
],
readonly_license_ssim: [
Expand All @@ -104,10 +104,10 @@
readonly_title_tesim: [
title3
],
'exhibit_abc_books_readonly_edm-rights_ssim': [
'exhibit_abc_books_readonly_rights_ssim': [
rights
],
'readonly_edm-rights_tesim': [
'readonly_rights_tesim': [
rights
],
exhibit_abc_books_readonly_license_ssim: [
Expand Down