Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject controlled vocabulary for Ephemera Folders doesn't expand/collapse. #5190

Closed
eliotjordan opened this issue Jun 14, 2022 · 5 comments
Closed

Comments

@eliotjordan
Copy link
Member

eliotjordan commented Jun 14, 2022

We used bootstrap-select to do this before, but the library's since changed and our old code is no longer working.

@tpendragon
Copy link
Contributor

The vocab wasn't in staging, so I added it, but all the subject categories are showing up expanded and can't be collapsed.

@tpendragon tpendragon self-assigned this Jun 15, 2022
@tpendragon
Copy link
Contributor

tpendragon commented Jun 15, 2022

Bootstrap-select has been upgraded and our old overrides in app/assets/javascripts/bootstrap_select_dropdown.js are no longer working.

I'm having a hard time fixing it - hiding the <li>s results in the select dropdown resizing wrong.

Things I've tried:

Rewrote the JS to get the optgroup from the class rather than a data attribute, and trigger off that. (resulted in big empty spaces post-collapse)
Tried snapappointments/bootstrap-select#2700 to fix the empty area - still happened.
Gave up.

@tpendragon tpendragon changed the title Upgrade: Ephemera vocabularies Subject controlled vocabulary for Ephemera Folders doesn't expand/collapse. Jun 16, 2022
@tpendragon tpendragon removed their assignment Jun 16, 2022
hackartisan added a commit that referenced this issue Jun 29, 2022
hackartisan added a commit that referenced this issue Jun 29, 2022
@hackartisan
Copy link
Member

I think this may be working now. Here's what it looks like for me locally

Screen Shot 2022-06-29 at 3.01.24 PM.png

@hackartisan
Copy link
Member

Oh wait they aren't grouped right.

@hackartisan
Copy link
Member

I got as far as successfully replicating the issue, hooray

tpendragon pushed a commit that referenced this issue Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants