Add checkpoint support to Pulp core and file #6245
Open
+843
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddavis
reviewed
Jan 30, 2025
|
I think we need docs as part of this PR. Maybe some on how plugin writers can enable this feature for their plugins in /docs/dev/learn/subclassing and then some user docs somewhere in /docs/user somewhere. |
Moustafa-Moustafa
force-pushed
the
main
branch
from
3049844 to
38ead76
Compare
daviddavis
reviewed
Jan 30, 2025
pulpcore/app/migrations/0127_distribution_checkpoint_publication_checkpoint.py
Outdated
Show resolved
Hide resolved
Moustafa-Moustafa
force-pushed
the
main
branch
2 times, most recently
from
ac5f9eb to
38ead76
Compare
Moustafa-Moustafa
force-pushed
the
main
branch
6 times, most recently
from
d778a95 to
19ceb1e
Compare
daviddavis
reviewed
Feb 10, 2025
Moustafa-Moustafa
force-pushed
the
main
branch
from
19ceb1e to
39f84ad
Compare
mdellweg
reviewed
Feb 11, 2025
pulpcore/tests/functional/api/using_plugin/test_content_access.py
Outdated
Show resolved
Hide resolved
Moustafa-Moustafa
force-pushed
the
main
branch
2 times, most recently
from
6f24ed7 to
9019fa5
Compare
mdellweg
reviewed
Feb 13, 2025
Introduce a checkpoint field for Publication and Distribution models. Handle serving checkpoint Publications via checkpoint Distributions. Protect checkpoint Publications' RepositoryVersions from cleanup. Enable checkpoint support in pulp_file. closes pulp#6244
Moustafa-Moustafa
force-pushed
the
main
branch
from
9019fa5 to
7780824
Compare
@mdellweg thanks for your insightful feedback, I'm confident this PR is in a better state thanks to your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for checkpoints in Pulp. This is related to this proposal . Publications can be marked as checkpoints at the creation time. Checkpoint publications are served through checkpoint distributions. Each repository can have 0-n checkpoint distributions, all serving the same content (i.e. the checkpoint publications).
The change adds a new field "checkpoint" to both the Distribution and Publication models. New publication can be made checkpoint publications by setting the checkpoint field. Checkpoint distributions can be created by setting the checkpoint field on the Distribution model and will serve all checkpoint publications. It's up to plugin writers to expose the checkpoint fields on their respective serializers.
This PR also enables the checkpoint support for pulp_file.
closes #6244