Preview is not always correct for stable output properties

[corymhall]

What happened?

Currently if you update a resource, all outputs are shown as computed
during preview. This means that downstream resources might show a
replacement in the plan if they are using one of those output values.

There are some outputs that we know will not change unless the resource
is replaced (I'm referring to these as "stable" outputs). For stable
outputs we can copy the value from the state in order to show an
accurate preview.

The problem is that the CCAPI schema has no way of determining
programmatically which outputs are stable and which are not. We took the first step in #1891, but we can do better

Couple of ideas on how we can handle this.

1. readOnly properties that are also a primaryIdentifier
   If a computed output is also part of the primary identifier of the resource then we should be able to assume that it is a stable output.
2. Create a schema overlay where users can contribute a list of stable outputs per resource. We already have an autoname overlay which we could adapt to be a generalized overlay.

Example

Note: this example won't show the issue after #1891 is merged.

const role = new aws.iam.Role('role', {
  assumeRolePolicy: aws.iam.assumeRolePolicyForPrincipal(
    aws.iam.Principals.LambdaPrincipal,
  ),
});

const asset = archive.getFile({
  type: 'zip',
  sourceFile: path.join(__dirname, 'apps', 'node-app', 'index.js'),
  outputPath: 'lambda_function_payload.zip',
});

const code = new pulumi.asset.FileArchive(asset.then((a) => a.outputPath));
const bucket = new aws.s3.BucketV2('bucket', {
  forceDestroy: true,
});
const object = new aws.s3.BucketObjectv2(
  'object-abcd',
  {
    source: code,
    bucket: bucket.bucket,
    key: 'abc.zip',
  },
);
const handler = new native.lambda.Function('my-function', {
  code: {
    s3Bucket: bucket.bucket,
    s3Key: object.key,
  },
  runtime: 'nodejs20.x',
  handler: 'index.handler',
  role: role.arn,
});

new native.lambda.Permission('permission', {
  functionName: handler.arn,
  action: 'lambda:InvokeFunction',
  principal: 's3.amazonaws.com',
});

Output of pulumi about

n/a

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).