Workflow failure: master #1234
Assignees
Labels
kind/engineering
Work that is not visible to an external user
needs-triage
Needs attention from the triage team
p1
A bug severe enough to be the next item assigned to an engineer
resolution/no-repro
This issue wasn't able to be reproduced
Comments
pulumi-bot
added
kind/engineering
|
Was a PR branch build to test publishing. Not on the main branch |
t0yv0
added a commit
that referenced
this issue
Jul 16, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
This change allows a program to set empty `instance_roles=[]` on an
eks.Cluster with custom `authentication_mode` without triggering a
warning on these properties being incompatible.
roleMappings and userMappings are treated symmetrically.
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
Fixes #1220
t0yv0
added a commit
that referenced
this issue
Jul 17, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
This change instructs TypeScript to avoid re-checking node_modules
(dependencies) in the examples/cluster.
### Related issues (optional)
This partially addresses
#1258
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
t0yv0
added a commit
that referenced
this issue
Jul 17, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
Upgrade google-protobuf from 3.21.2 inherited from @pulumi/pulumi to
3.21.4 (the latest version). This affects both the provider and the Node
SDK that are coupled together in this provider.
Fixes spontaneous failure of TestAccAwsCluster and many other tests.
Typical failure:
```
Resources:
+ 1 to create
command.go:98: Invoke '/usr/local/bin/pulumi preview --non-interactive --diff' failed: exit status 255
command.go:121: Command completed without output
program.go:1066: [/usr/local/bin/pulumi preview --non-interactive --diff] failed: exit status 255; retrying...
command.go:46: **** Invoke '/usr/local/bin/pulumi preview --non-interactive --diff' in '/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546'
Previewing update (p-it-fv-az692-2-aws-profil-d12a0b7a):
warning: using pulumi-resource-eks from $PATH at /home/runner/work/pulumi-eks/pulumi-eks/bin/pulumi-resource-eks
+ pulumi:pulumi:Stack: (create)
[urn=urn:pulumi:p-it-fv-az692-2-aws-profil-d12a0b7a::example-aws-profile::pulumi:pulumi:Stack::example-aws-profile-p-it-fv-az692-2-aws-profil-d12a0b7a]
error: Running program '/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546/' failed with an unhandled exception:
<ref *1> TypeError: c.g is not a function
at Function.N.setWrapperField (/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546/node_modules/google-protobuf/google-protobuf.js:91:66)
at proto.pulumirpc.RegisterResourceRequest.setObject (/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546/node_modules/@pulumi/pulumi/proto/resource_pb.js:2511:23)
at Object.<anonymous> (/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546/node_modules/@pulumi/runtime/resource.ts:486:17)
at Generator.next (<anonymous>)
at fulfilled (/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546/node_modules/@pulumi/pulumi/runtime/resource.js:18:58) {
promise: Promise { <rejected> [Circular *1] }
}
```
### Related issues (optional)
Partially addresses #1258
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
t0yv0
added a commit
that referenced
this issue
Jul 17, 2024
It may be sufficient to have the updated version in the yarn.lock file without hard-coding the dependency as a constraint in package.json file. Fixes changes introduced in #1262 <!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md) for Pulumi's contribution guidelines. Help us merge your changes more quickly by adding more details such as labels, milestones, and reviewers.--> ### Proposed changes <!--Give us a brief description of what you've done and what it solves. --> ### Related issues (optional) <!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other GitHub repositories. -->
|
This issue has been addressed in PR #1227 and shipped in release v2.7.4. |
|
This issue has been addressed in PR #1227 and shipped in release v2.7.5. |
|
This issue has been addressed in PR #1227 and shipped in release v2.7.6. |
t0yv0
added a commit
that referenced
this issue
Jul 30, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
This should help with the flaky TestAccPy test.
Fixes #1278
Fixes #1279
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
|
This issue has been addressed in PR #1282 and shipped in release v2.7.7. |
flostadler
pushed a commit
that referenced
this issue
Sep 4, 2024
…Cluster` (#1122) <!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md) for Pulumi's contribution guidelines. Help us merge your changes more quickly by adding more details such as labels, milestones, and reviewers.--> ### Proposed changes <!--Give us a brief description of what you've done and what it solves. --> ### Related issues (optional) <!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other GitHub repositories. --> Related: #1031
flostadler
pushed a commit
that referenced
this issue
Sep 4, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
This change allows a program to set empty `instance_roles=[]` on an
eks.Cluster with custom `authentication_mode` without triggering a
warning on these properties being incompatible.
roleMappings and userMappings are treated symmetrically.
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
Fixes #1220
flostadler
pushed a commit
that referenced
this issue
Sep 4, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
This change instructs TypeScript to avoid re-checking node_modules
(dependencies) in the examples/cluster.
### Related issues (optional)
This partially addresses
#1258
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
flostadler
pushed a commit
that referenced
this issue
Sep 4, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
Upgrade google-protobuf from 3.21.2 inherited from @pulumi/pulumi to
3.21.4 (the latest version). This affects both the provider and the Node
SDK that are coupled together in this provider.
Fixes spontaneous failure of TestAccAwsCluster and many other tests.
Typical failure:
```
Resources:
+ 1 to create
command.go:98: Invoke '/usr/local/bin/pulumi preview --non-interactive --diff' failed: exit status 255
command.go:121: Command completed without output
program.go:1066: [/usr/local/bin/pulumi preview --non-interactive --diff] failed: exit status 255; retrying...
command.go:46: **** Invoke '/usr/local/bin/pulumi preview --non-interactive --diff' in '/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546'
Previewing update (p-it-fv-az692-2-aws-profil-d12a0b7a):
warning: using pulumi-resource-eks from $PATH at /home/runner/work/pulumi-eks/pulumi-eks/bin/pulumi-resource-eks
+ pulumi:pulumi:Stack: (create)
[urn=urn:pulumi:p-it-fv-az692-2-aws-profil-d12a0b7a::example-aws-profile::pulumi:pulumi:Stack::example-aws-profile-p-it-fv-az692-2-aws-profil-d12a0b7a]
error: Running program '/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546/' failed with an unhandled exception:
<ref *1> TypeError: c.g is not a function
at Function.N.setWrapperField (/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546/node_modules/google-protobuf/google-protobuf.js:91:66)
at proto.pulumirpc.RegisterResourceRequest.setObject (/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546/node_modules/@pulumi/pulumi/proto/resource_pb.js:2511:23)
at Object.<anonymous> (/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546/node_modules/@pulumi/runtime/resource.ts:486:17)
at Generator.next (<anonymous>)
at fulfilled (/tmp/p-it-fv-az692-2-aws-profil-d12a0b7a-1252542546/node_modules/@pulumi/pulumi/runtime/resource.js:18:58) {
promise: Promise { <rejected> [Circular *1] }
}
```
### Related issues (optional)
Partially addresses #1258
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
flostadler
pushed a commit
that referenced
this issue
Sep 4, 2024
It may be sufficient to have the updated version in the yarn.lock file without hard-coding the dependency as a constraint in package.json file. Fixes changes introduced in #1262 <!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md) for Pulumi's contribution guidelines. Help us merge your changes more quickly by adding more details such as labels, milestones, and reviewers.--> ### Proposed changes <!--Give us a brief description of what you've done and what it solves. --> ### Related issues (optional) <!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other GitHub repositories. -->
flostadler
pushed a commit
that referenced
this issue
Sep 4, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
This should help with the flaky TestAccPy test.
Fixes #1278
Fixes #1279
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
t0yv0
added a commit
that referenced
this issue
Sep 6, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
Enable the use of direnv with this repo.
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
corymhall
added a commit
that referenced
this issue
Sep 20, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
The coredns managed addon can only be deployed on clusters with default
node
groups (which includes Fargate clusters).
<!--Give us a brief description of what you've done and what it solves.
-->
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
t0yv0
added a commit
that referenced
this issue
Sep 26, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
Similar to how master.yml works, this change allows to trigger
release.yml manually and point it to a WIP branch. This will help us out
to test alpha releases and changes to the release workflow for the 3.x.x
series.
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
t0yv0
added a commit
that referenced
this issue
Sep 26, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
Similar to how master.yml works, this change allows to trigger
release.yml manually and point it to a WIP branch. This will help us out
to test alpha releases and changes to the release workflow for the 3.x.x
series.
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
t0yv0
added a commit
that referenced
this issue
Oct 14, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
Reading the documentation on this job:
```
GitHub Action Artifacts are removed after [90 days](https://github.community/t5/GitHub-Actions/Managing-Actions-storage-space/m-p/41424/highlight/true#M4618) by default.
[GitHub now supports changing this setting](https://github.blog/changelog/2020-10-08-github-actions-ability-to-change-retention-days-for-artifacts-and-logs/). This action allows you to further customize the cleanup.
```
Fixes #1434
The proposed change is to rely on automatic 90-day cleanup and avoid P1
interrupts around the failures of this job.
<!--Give us a brief description of what you've done and what it solves.
-->
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
t0yv0
added a commit
that referenced
this issue
Oct 16, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
Backport 3.x changes that make examples compute the latest coredns addon
version instead of using an outdated version and failing.
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
Fixes #1444
Fixes #1437
flostadler
pushed a commit
that referenced
this issue
Oct 17, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
The coredns managed addon can only be deployed on clusters with default
node
groups (which includes Fargate clusters).
<!--Give us a brief description of what you've done and what it solves.
-->
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
flostadler
pushed a commit
that referenced
this issue
Oct 17, 2024
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
The coredns managed addon can only be deployed on clusters with default
node
groups (which includes Fargate clusters).
<!--Give us a brief description of what you've done and what it solves.
-->
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
|
This issue has been addressed in PR #1393 and shipped in release v3.0.0. |
flostadler
added a commit
that referenced
this issue
Nov 19, 2024
The generated kubeconfig is missing the region argument. This can lead to issues in many scenarios, e.g. when a user has `AWS_DEFAULT_REGION` set or when they have no default region set and use the provider configuration for setting the pulumi region (i.e. `aws:region`). This aligns the provider with how the AWS CLI generates the kubeconfig (`aws eks update-kubeconfig`). This change uses the cluster ARN to identify the cluster's region and sets it in the kubeconfig. The k8s provider's `kubeconfig` property will not trigger replacements. Multiple upgrade tests validate this (e.g. `aws-profile`). <!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other GitHub repositories. -->
|
This issue has been addressed in PR #1498 and shipped in release v3.2.0. |
|
This issue has been addressed in PR #1496 and shipped in release v3.3.0. |
|
This issue has been addressed in PR #1523 and shipped in release v3.5.0. |
t0yv0
added a commit
that referenced
this issue
Dec 23, 2024
It is possible to validate Renovate configuration with:
npx --yes --package renovate -- renovate-config-validator
Fixes #1548
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
|
This issue has been addressed in PR #1551 and shipped in release v3.6.0. |
rquitales
added a commit
that referenced
this issue
Jan 28, 2025
### Proposed changes This PR revives #1474 by rebasing and modifying to fit the latest changes to pulumi-eks and ci-mgmt. Changes made: - Restructure the go modules to align with bridged providers for now - Generated ci-mgmt workflows - Added kubectl installation as a setup step - Runs all tests in parallel across 25 shards (including upgrade tests) Passing alpha release: https://github.com/pulumi/pulumi-eks/actions/runs/13015734092 ### Related issues (optional) <!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes #1234'. Or link to full URLs to issues or pull requests in other GitHub repositories. -->
|
This issue has been addressed in PR #1596 and shipped in release v3.8.1. |
t0yv0
added a commit
that referenced
this issue
Jan 30, 2025
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
#1576 merged where it shouldn't
have.
Looks like failures in `make renovate` do not block renovate merges.
Another problem is that CI regressed on having checks that ensure the
generated SDKs are up to date.
While we fix these issues I suggest we disable renovate auto-merges.
<!--Give us a brief description of what you've done and what it solves.
-->
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
t0yv0
added a commit
that referenced
this issue
Jan 30, 2025
<!--Thanks for your contribution. See [CONTRIBUTING](CONTRIBUTING.md)
for Pulumi's contribution guidelines.
Help us merge your changes more quickly by adding more details such
as labels, milestones, and reviewers.-->
### Proposed changes
<!--Give us a brief description of what you've done and what it solves.
-->
After recent changes, Renovate bot invokes `make renovate` that
delegates to ./script/renovate.sh but we omitted checking that in. Here
is a version adapted from pulumi-awsx that should re-generate the
dependencies and dedup the deps.
### Related issues (optional)
<!--Refer to related PRs or issues: #1234, or 'Fixes #1234' or 'Closes
#1234'.
Or link to full URLs to issues or pull requests in other GitHub
repositories. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Workflow Failure
master has failed. See the list of failures below:
The text was updated successfully, but these errors were encountered: