Exclude Non-Loadable Packages from ClassLoader. Fixes #issue 1385

[andreaspartisia]

Description

We encountered an issue with the package loader that loads every package indiscriminately, instead of using the Maven class loader's smart loading. This is a known problem, and while some packages have already been excluded, the process requires a merge request for each exclusion. Therefore, we identified the need for a faster and more dynamic exclusion mechanism.

This fix introduces a system property string containing a comma-separated list of packages to exclude. By setting this property, the specified packages will be excluded from the loaded packages.

Fixes #1385

Checklist

• I have added tests that prove my fix is effective or that my feature works

• I have updated the CHANGELOG-PENDING file with my change

• Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

[justinvp]

Thanks for the contribution! I left some review comments. This also needs a test before we can merge it.

[andreaspartisia]

Thanks for the review @justinvp

I have corrected it now and made a test for a the exclusion of packages.

[justinvp]

Looks good to me. Thanks!

@andreaspartisia, looks like there's a conflict with the pulumi submodule. Can you revert that change?

[andreaspartisia]

Yes @justinvp it has been updated now.

[andreaspartisia]

@justinvp
Do you have time to look at this again?

[justinvp]

/run-acceptance-tests

[justinvp]

@andreaspartisia, thanks for your patience!

I opened a temp PR to run the tests in CI and the new test is failing:

https://github.com/pulumi/pulumi-java/actions/runs/10464711824/job/28978759154?pr=1412#step:12:376

ResourcePackagesTest > ExcludedResource() FAILED
    java.lang.AssertionError: Test resource was found
        at com.pulumi.serialization.internal.ResourcePackagesTest.ExcludedResource(ResourcePackagesTest.java:91)

[andreaspartisia]

Thanks for the reminder @justinvp
It was because all test used the same JVM in parallel testing, so they polluted each other, but I have made my test run in it's own JWM, so it's fine now.
I hope you have time to look at it again.

[andreaspartisia]

@justinvp do you have time to look at it again or do one of your colleagues have time for it?

[justinvp]

/run-acceptance-tests

[justinvp]

LGTM! I'll get it merged after reviewing the test run.

Note: we were running into some unrelated lint issues in CI in this repo yesterday that we may need to fix separately, so it may be another day or so. Thanks for your patience and thanks again for addressing this!