Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent property names across resources for TeamStackPermission, DeploymentSettings, StackTag and TeamStackPermissionArgs #201

Open
aureq opened this issue Nov 21, 2023 · 1 comment
Labels
customer/feedback Feedback from customers kind/enhancement Improvements or new features

Comments

@aureq
Copy link
Member

aureq commented Nov 21, 2023

What happened?

The resources TeamStackPermission, DeploymentSettings, StackTag and TeamStackPermissionArgs have the following properties

  • .organization
  • .project
  • .stack
  • .team

However, Team, TeamAccessToken, OrgAccessToken and Webhook, use the following properties

  • .organizationName
  • .projectName
  • .stackName
  • .teamName

Either way, it would give a more consistent and improved user experience if the property names were consistently named across all the resources for this provider. Using ...Name as a suffix makes it easier imho.

This will introduce some breaking change for the resources affected by the change, however, since it's still in v0 maybe it's acceptable.

Example

n/a

Output of pulumi about

n/a

Additional context

This issue happens on the latest version 0.16.0.

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@aureq aureq added kind/bug Some behavior is incorrect or out of spec customer/feedback Feedback from customers needs-triage Needs attention from the triage team labels Nov 21, 2023
@lukehoban lukehoban added kind/enhancement Improvements or new features and removed kind/bug Some behavior is incorrect or out of spec labels Nov 21, 2023
@cleverguy25 cleverguy25 removed the needs-triage Needs attention from the triage team label Nov 21, 2023
@komalali komalali added this to the 0.112 milestone Oct 15, 2024
@komalali komalali removed this from the 0.112 milestone Nov 13, 2024
@IaroslavTitov
Copy link
Contributor

This should be mostly solved by #462, but for team vs teamName I'll go through and make sure to standartize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer/feedback Feedback from customers kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

5 participants