Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Housekeeping] Eliminate useless files #465

Open
IaroslavTitov opened this issue Dec 9, 2024 · 0 comments
Open

[Housekeeping] Eliminate useless files #465

IaroslavTitov opened this issue Dec 9, 2024 · 0 comments
Labels
kind/task Work that's part of an ongoing epic

Comments

@IaroslavTitov
Copy link
Contributor

IaroslavTitov commented Dec 9, 2024 •
edited
Loading

Summary

  • While looking around planning for PSPV1, noticed files called version.go and serve.go
    • Both are very short and don't seem to need to be there
    • investigate and eliminate extra files if possible
  • There is also a unkown.go file representing an unknown resource
    • Remove that file - we can throw errors directly
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 9, 2024
@komalali komalali added kind/task Work that's part of an ongoing epic and removed needs-triage Needs attention from the triage team labels Dec 10, 2024
@IaroslavTitov IaroslavTitov mentioned this issue Jan 10, 2025
Merged
IaroslavTitov added a commit that referenced this issue Jan 13, 2025
@IaroslavTitov
Fix passing in version on provider build (#486)
ff33846 
### Summary
- Fixes: #477
- Fixes the first bullet point of
#465
- Fixing missed Version insertion using -ldflags
- Moving location of Version to main.go to eliminate empty file
- Moving serve.go logic to main.go to pull out serving logic out of
provider package
- Minor cleanup of Makefile - creating one BUILD_PATH variable to avoid
repeating path blocks
- Adding missed version specification for java sdk generation

### Summary
- Tested build works locally and provider works as expected
- Integ tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task Work that's part of an ongoing epic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@IaroslavTitov @komalali @pulumi-bot