Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Diff methods #481

Open
IaroslavTitov opened this issue Dec 19, 2024 · 0 comments
Open

Standardize Diff methods #481

IaroslavTitov opened this issue Dec 19, 2024 · 0 comments
Labels
kind/enhancement Improvements or new features

Comments

@IaroslavTitov
Copy link
Contributor

Summary

  • I noticed that Diff methods are very similar, the only difference being the replace properties pretty much
  • Create a shared method for all resources to use
  • Some of the replace logic can be handled by adding "replaceOnChange" in the schema? Test this and remove explicit logic if that's the case!
@pulumi-bot pulumi-bot added the needs-triage Needs attention from the triage team label Dec 19, 2024
@cleverguy25 cleverguy25 added kind/enhancement Improvements or new features and removed needs-triage Needs attention from the triage team labels Dec 23, 2024
@cleverguy25 cleverguy25 changed the title Standartize Diff methods Standardize Diff methods Dec 23, 2024
@IaroslavTitov IaroslavTitov mentioned this issue Jan 8, 2025
Merged
IaroslavTitov added a commit that referenced this issue Jan 21, 2025
@IaroslavTitov
Creating OIDC Issuer resource (#484)
56217dc 
### Summary
- Fixes: #349
- Adding new OIDC Issuer resource
- Adding OIDC client
- Adding standard diff logic, to reuse in most (if not all!) resources -
this would be used in
#481
- @glena , please take a look, since I only know the basics when it
comes to how OIDC works, let me know if this makes sense

### Testing
- Adding examples/integ tests in C#, TS, yaml
- I had to add `service-provider-test-org2` and
`service-provider-test-org3`, since otherwise examples would collide
with each other
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvements or new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cleverguy25 @IaroslavTitov @pulumi-bot