Rename DeploymentSettingsArgs.operationContext.oidc.gcp.projectId to projectNumber

[kdawgwilk]

What happened?

This was a major footgun for me as I was setting up pulumi OIDC with GCP. Google's project id is actually very different than the project number. The project id in GCP is a text based value and this field in pulumi's OIDC settings needs the project number.

Example

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

[komalali]

This would be a breaking change, so we'd need to carefully consider how we handle this. We can perhaps improve the documentation here to prevent the footgun - but changing the property name is a bit of a more complicate change.

[kdawgwilk]

The project is still listed as a public preview right? I would expect breaking changes from a preview library not sure about others. I see this is a big enough issue for to warrant the breaking change IMO. Our team wasted multiple days and then back and forth emails with support trying to track down what the issue was.

However, if that is still a concern I think the best case scenario would be to deprecate the current property so IDEs can call out that it shouldn't be used and then add a new property with the new name that lives alongside the old name until the deprecated field is removed. If both properties are passed I would favor the new correctly named property over the old.