Skip to content

Commit

Permalink
Revert go.mod back to go 1.21 (#662)
Browse files Browse the repository at this point in the history
To match pulumi/pulumi's `pkg/go.mod` which is also set to `go 1.21`.

Also, use go 1.22 in CI rather than go 1.23, since we still want
pulumi/pulumi's pkg to be usable with go 1.22 without requiring another
toolchain version.
  • Loading branch information
justinvp authored Oct 10, 2024
1 parent d3fd26c commit ec5a00f
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 5 deletions.
6 changes: 6 additions & 0 deletions .changes/unreleased/Bug Fixes-662.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
component: runtime
kind: Bug Fixes
body: Revert go version in go.mod back to 1.21
time: 2024-10-09T15:05:26.676777-07:00
custom:
PR: "662"
6 changes: 3 additions & 3 deletions .github/workflows/stage-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ permissions: read-all
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GOLANGCI_LINT_VERSION: v1.60
GO_VERSION: v1.23.x
GO_VERSION: v1.22.x

jobs:
lint:
Expand All @@ -22,7 +22,7 @@ jobs:
go-version: ${{ env.GO_VERSION }}
cache-dependency-path: |
**/go.sum
- run: go mod tidy -go=1.23
- run: go mod tidy -go=1.21
- name: Fail if go mod tidy changed go.mod
run: |
if [ -n "$(git status --porcelain)" ]; then
Expand Down Expand Up @@ -50,6 +50,6 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.23.x
go-version: 1.22.x
- name: Lint
run: make lint-copyright
2 changes: 1 addition & 1 deletion .github/workflows/stage-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,4 +146,4 @@ jobs:
strategy:
fail-fast: false
matrix:
go-version: [1.23.x]
go-version: [1.22.x]
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/pulumi/pulumi-yaml

go 1.23
go 1.21

require (
github.com/blang/semver v3.5.1+incompatible
Expand Down

0 comments on commit ec5a00f

Please sign in to comment.