-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address overview pages that do not meet content requirements #5307
Labels
Comments
The check is here: registry/scripts/ci/validate-packages.sh Lines 50 to 51 in 13f5f8f
|
Let's reconsider this as a P1. I'm not sure we should address this in the general case, but I'm doubly unsure this needs to be prioritized to the next item, having sat unaddressed and unassigned for 2 months. |
|
iwahbe
added a commit
that referenced
this issue
Jan 24, 2025
- Remove `junipermist` and `sdwan` from the exception list (as they now pass the lint) - Add an explanation to why `heroku` and `packet` will be permanent exceptions. This fixes #5307, minimizing the exception list as much as possible given reasonable effort.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
We added a check to the registry to ensure the package overview page is not blank and also contains a minimal amount of content (at least 250 characters). We have added the current failing packages to an exceptions list for now in order to get the tests passing until these get addressed.
Here is a list of the current failures:
We need to get heroku, junipermist, meraki, packet, and sdwan addessed.
The text was updated successfully, but these errors were encountered: