Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate updating pinned external provider references #263

Open
t0yv0 opened this issue May 20, 2024 · 1 comment
Open

Automate updating pinned external provider references #263

t0yv0 opened this issue May 20, 2024 · 1 comment
Labels
kind/enhancement Improvements or new features

Comments

@t0yv0
Copy link
Member

t0yv0 commented May 20, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

To stabilize provider builds we currently pin external provider references so that examples that use an external provider (i.e. aws provider when building a provider other than aws such as awsx) render in a stable manner. However issues remain when these references remain stale. Examples drop out or render inaccurately.

How are these pinned? See .ci-mgmt.yaml in pulumi-aws for a good recent example, it has a section:

plugins:
  - name: archive
    version: "0.0.1"
  - name: tls
    version: "4.10.0"
  - name: github
    version: "4.10.0"
  - name: kubernetes
    version: "4.11.0"
  - name: "null"
    version: "0.0.3"
  - name: "local"
    version: "0.1.0"
  - name: random
    version: "4.8.2"
  - name: github
    version: "5.14.0"
  - name: std
    version: "1.6.2"
  - name: terraform
    version: "1.0.17"
    kind: converter

Suggest automating this:

  • read plugins
  • for each plugin find the latest version on Pulumi
  • if below latest version, edit it
  • stop after first plugin
  • make tfgen
  • check in the code and create a PR

Affected area/feature

@t0yv0 t0yv0 added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels May 20, 2024
@iwahbe
Copy link
Member

iwahbe commented May 20, 2024

I think this is a great idea.

As part of doing this, we should move plugin versions to a separate lock file. I don't want upgrade-provider to be editing .ci-mgmt.yaml.

@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants