Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option: ranger-travel-use-counsel #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add option: ranger-travel-use-counsel #141

wants to merge 1 commit into from

Conversation

dieggsy
Copy link

@dieggsy dieggsy commented Feb 15, 2017

ranger-travel uses counsel instead of helm if counsel is available and this option is set to t.

@punassuming
Copy link
Owner

Sorry for the delay. I don't think it needs a variable. Lets just place this cond below the (featurep 'helm) cond and we should be good.

@dieggsy
Copy link
Author

dieggsy commented Mar 17, 2017

Well, that would be fine, but some people might use both helm and counsel (I don't personally), which is why I thought the option might be nice - so it the user has the option, rather than it defaulting to the first package chosen in the code.

@braham-snyder
Copy link
Contributor

braham-snyder commented May 7, 2017

+1 -- I generally prefer counsel/ivy as well, but I currently have helm installed incidentally as a dependency of org-ref (though it additionally lists ivy as a dependency, which is a bit odd--I haven't looked into this yet).

edit: regarding org-ref, it currently requires helm even when actually used with only ivy due to complications with MELPA packaging: jkitchin/org-ref#231

edit 2: would just read-file-name work after the user has run helm-mode (through completing-read-function)? or does that exclude some additional helm functionality? it works well for ivy when using ivy-mode

@punassuming
Copy link
Owner

@braham-snyder , I will try with read-file-name to see if that meets all of our needs. I don't have any added functionality yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants