improve case detection for ranger-travel #236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check that helm/ivy/ido-mode is on rather than the library being around - default to read-file-name instead of ido-read-file-name, since the latter doesn't work if ido isn't on.
iyefrat
added a commit
to iyefrat/doom-emacs
that referenced
this pull request
Oct 4, 2021
Overrides ranger-travel to have better mode detection for which completion framework to use, and default to emacs built-ins instead of ido. In theory this should be a temporary fix until punassuming/ranger.el#236 gets merged, but the maintenance status of ranger.el is not clear. Fix doomemacs#5509 Ref punassuming/ranger.el#236
hlissner
pushed a commit
to doomemacs/doomemacs
that referenced
this pull request
Oct 5, 2021
Overrides ranger-travel to have better mode detection for which completion framework to use, and default to emacs built-ins instead of ido. In theory this should be a temporary fix until punassuming/ranger.el#236 gets merged, but the maintenance status of ranger.el is not clear. Fix #5509 Ref punassuming/ranger.el#236
peterhoeg
pushed a commit
to peterhoeg/doomemacs
that referenced
this pull request
Oct 22, 2021
Overrides ranger-travel to have better mode detection for which completion framework to use, and default to emacs built-ins instead of ido. In theory this should be a temporary fix until punassuming/ranger.el#236 gets merged, but the maintenance status of ranger.el is not clear. Fix doomemacs#5509 Ref punassuming/ranger.el#236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
around
latter doesn't work if ido isn't on.