Skip to content
This repository has been archived by the owner on Mar 28, 2019. It is now read-only.

Add test coverage for Gentoo codebase #145

Open
1 of 5 tasks
danieldreier opened this issue Nov 27, 2014 · 3 comments
Open
1 of 5 tasks

Add test coverage for Gentoo codebase #145

danieldreier opened this issue Nov 27, 2014 · 3 comments
Milestone

Comments

@danieldreier
Copy link
Contributor

Based on issue #136 and @tampakrap's feedback on PR #140 we ought to fix Gentoo support rather than dropping it.

Gentoo Support To-Do List

  • Add rspec-puppet test coverage given the facts that would be expected in a Gentoo environment
  • Add a Gentoo beaker nodeset (what version(s) of Gentoo need coverage?)
  • Run tests and fix the inevitable issues that are discovered
  • Can we move gentoo_use and gentoo_keywords parameters from puppet::agent and puppet::server to puppet::params? I don't feel like we should have distro/OS specific parameters outside of params unless absolutely necessary. (but I don't understand what those parameters do, so that may be a bad idea)
  • Add gentoo test coverage to the other puppet modules we depend on. This is a ton of work, but our ability to support a platform (and the troubleshooting effort involved in it) is massively higher when dependencies break

Anything else people can think of? I don't mean to be overly project-manager-y, just hoping that making a more specific list of tasks will make it easier to support the platform.

@tampakrap
Copy link
Contributor

Regarding 2: Gentoo is a rolling distro, doesn't have versions
Regarding 4: Please drop gentoo_use and gentoo_keywords completely. It's a hack I introduced in a bunch of modules that I introduced Gentoo support. There was a discussion about this in a Puppet ticket in order to support such package specific params through a hash (BSD was also facing a similar issue)

@tampakrap
Copy link
Contributor

this will help a bit #169

@danieldreier
Copy link
Contributor Author

thanks @tampakrap, great to see movement on this.

@zachfi zachfi modified the milestone: 1.0.0 May 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants