Agents-to-masters service is identical to master service

[skoef]

Describe the Bug

In the chart, once you enable the use of separate compilers, the service described in templates/puppetserver-service-agents-to-masters.yaml (canonically called agents-to-puppet) is created. This service is, except for the name, 100% identical to the service describe in templates/puppetserver-service-masters.yaml (called puppet). Also, still with compilers enabled, the service described in templates/puppetserver-service-compilers.yaml (called puppet-compilers) is created.

I don't understand why there should be two identical services, both with the master pods as endpoints.

Expected Behavior

In my setup, I point my agents to the puppet service as their ca_server and to the puppet-compilers service as their server. This works fine.

Steps to Reproduce

Steps to reproduce the behavior:

1. Install the chart with --set puppetserver.compilers.enabled=true
2. See how identical the puppet and agents-to-puppet services are and how they have identical endpoints
3. See how the puppet-compilers service is the only relevant service to reach the compilers considered both puppet-compilers and agents-to-puppet.

Environment

• Version: chart 6.3.0
• Platform: kubernetes/helm

Additional Context

I think the agents-to-puppet service can be dropped altogether. Unless I don't understand the reasoning behind it. Please, enlighten me! :)