Allow to specify a node port

[qdii]

Use Case

On bare metal installations of Kubernetes, it is often useful to set up services of type NodePort to make a node's port available for the service.

Currently, the helm chart allow to change the type of the service, but note to specify a nodePort, which results in this port to be randomly allocated. Worse, the port isn't stable through upgrades of the charts.

Describe the Solution You Would Like

An additional nodePort field should be available in the chart.

Describe Alternatives You've Considered

TLS passthrough via Ingress may be a workaround.

Additional Context

None

[ldaneliukas]

Hey!

Does the following not meet your needs:

puppetserver:
  masters:
    service:
      type: NodePort
      ports:
        puppetserver:
          port: 8140
          nodePort: 18140
          protocol: TCP

Results in:

NAME                         TYPE        CLUSTER-IP       EXTERNAL-IP   PORT(S)
puppetserver-puppet          NodePort    10.252.178.61    <none>        8140:18140/TCP

[qdii]

That sounds perfect!

[ldaneliukas]

@qdii you seem to have re-opened this, can it be closed?

[qdii]

I think it can, however just a question: I can see that in templates/puppetserver-service-masters:

apiVersion: v1
kind: Service
metadata:
  ...
spec:
  ports:
    ...
  selector:
    ...
{{- if .Values.puppetserver.compilers.enabled }}
  type: ClusterIP
{{- else }}
  type: {{ .Values.puppetserver.masters.service.type }}
  {{- if (and (eq .Values.puppetserver.masters.service.type "LoadBalancer") (not (empty .Values.puppetserver.masters.service.loadBalancerIP))) }}
  loadBalancerIP: {{ .Values.puppetserver.masters.service.loadBalancerIP }}
  {{- end }}
{{- end }}

Does this mean that if compilers.enable = True, then it is not possible to define the service as a NodePort? (and is there a limitation why?)

[davidphay]

Yes it's correct.
for now you have to use a reverse proxy like traefik or nginx.

I guess we should update this parts to be able to update this field with a variable.

Feel free to fix the issue with a PR :)