You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#125 introduced extraSecrets and these are added as volumes to all pods. The issue is, there they are not actually mounted (i.e. no volumeMounts are created). So whilst the secret is added, it can't really be used for anything within the existing containers.
Expected Behavior
The value for extraSecrets should require not only a name but a mountPath too, which would create volume mounts on the specified path in all containers. Changing it to a hash with key being the secret name and value the path could work, for example:
Hi @ldaneliukas, I see this has not been yet fixed. Do you mind if I open a PR using your solution? I thought about changing extrasecrets to an array of objects like this:
Describe the Bug
#125 introduced
extraSecrets
and these are added as volumes to all pods. The issue is, there they are not actually mounted (i.e. no volumeMounts are created). So whilst the secret is added, it can't really be used for anything within the existing containers.Expected Behavior
The value for
extraSecrets
should require not only aname
but amountPath
too, which would create volume mounts on the specified path in all containers. Changing it to a hash with key being the secret name and value the path could work, for example:Then:
Steps to Reproduce
extraSecrets
in your values.Additional Context
I can create a PR for this.
The text was updated successfully, but these errors were encountered: