From a3be5565e05be89da6e2ae5e69f46e1ee075cecf Mon Sep 17 00:00:00 2001 From: Mayank Patibandla <34776435+mayankpatibandla@users.noreply.github.com> Date: Sun, 24 Mar 2024 00:29:52 -0400 Subject: [PATCH] Fix W0223 --- .pylintrc | 3 +-- pros/cli/click_classes.py | 3 ++- pros/serial/devices/vex/stm32_device.py | 4 ++++ pros/serial/ports/serial_share_port.py | 4 ++++ 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/.pylintrc b/.pylintrc index c2f4da35..779164a2 100644 --- a/.pylintrc +++ b/.pylintrc @@ -14,7 +14,6 @@ # W0401: Wildcard import # R1725: Super with arguments # W0237: Renamed arguments -# W0223: Abstract method is not overridden # W0613: Unused argument # W0511: TODO # C0103: Variable name doesn't conform to naming style @@ -58,7 +57,7 @@ max-line-length = 120 disable = C0114, C0115, C0116, R0903, C0415, R0913, W1203, R1729, E1120, E1123, C0209, R1710, W0621, - W0614, W0401, W1202, W0718, R0914, R1725, C0411, W0237, W0702, W0223, W0613, + W0614, W0401, W1202, W0718, R0914, R1725, C0411, W0237, W0702, W0613, R0912, R0911, W0511, R0902, C0412, C0103, C0301, R0915, W1514, E1101, W1201, E0401, W0212, R0904, W0101, diff --git a/pros/cli/click_classes.py b/pros/cli/click_classes.py index 9cdb75b9..0460ad5c 100644 --- a/pros/cli/click_classes.py +++ b/pros/cli/click_classes.py @@ -67,7 +67,8 @@ class PROSCommand(PROSFormatted, click.Command): # Seems to be unused? class PROSMultiCommand(PROSFormatted, click.MultiCommand): - pass + def get_command(self, ctx: click.Context, cmd_name: str) -> Optional[click.Command]: + pass class PROSOption(click.Option): diff --git a/pros/serial/devices/vex/stm32_device.py b/pros/serial/devices/vex/stm32_device.py index 23e6f05b..db67150e 100644 --- a/pros/serial/devices/vex/stm32_device.py +++ b/pros/serial/devices/vex/stm32_device.py @@ -8,6 +8,7 @@ from pros.common import ui from pros.common import logger, retries +from pros.conductor import Project from pros.serial import bytes_to_str from pros.serial.devices.vex import VEXCommError from pros.serial.ports import BasePort @@ -189,3 +190,6 @@ def _txrx_command(self, command: Union[int, bytes], timeout: float = 0.01, check if data[0] == self.ACK_BYTE: return raise VEXCommError(f"Device never ACK'd to {command}", command) + + def upload_project(self, project: Project, **kwargs): + pass diff --git a/pros/serial/ports/serial_share_port.py b/pros/serial/ports/serial_share_port.py index 2ee58587..14c18910 100644 --- a/pros/serial/ports/serial_share_port.py +++ b/pros/serial/ports/serial_share_port.py @@ -82,3 +82,7 @@ def _kick_watchdog(self): self.to_device_sock.send_multipart([b'kick']) self.alive.wait(2.5) logger(__name__).info('Watchdog kicker is dying') + + @property + def name(self): + pass