Add type level format builder #27
Conversation
|
Was playing with this staff and this is what I came to.
|
|
Could you add some examples please? |
| , ValidSecondsType secondsOut | ||
| , ValidateMilliseconds a NoMilliseconds millisecondsOut | ||
| , ValidMillisecondsType millisecondsOut | ||
| ) ⇒ ValidTimeI a |
| ) ⇒ ValidDate a | ||
|
|
||
| class ValidDateI (a ∷ FormatList) | ||
| instance vdi ∷ ValidDateI a |
There was a problem hiding this comment.
I have not implemented it date staff yet.
Here needs to go minute and seccond like checks for year month ....
| instance rdi18 ∷ PrintFormatI rest ⇒ PrintFormatI (SecondsTwoDigits : rest) where printFormatI _ acc = printFormatI (FProxy ∷ FProxy rest) (flip Cons acc FC.SecondsTwoDigits) | ||
| instance rdi19 ∷ PrintFormatI rest ⇒ PrintFormatI (Milliseconds : rest) where printFormatI _ acc = printFormatI (FProxy ∷ FProxy rest) (flip Cons acc FC.Milliseconds) | ||
| instance rdi20 ∷ PrintFormatI rest ⇒ PrintFormatI (MillisecondsShort : rest) where printFormatI _ acc = printFormatI (FProxy ∷ FProxy rest) (flip Cons acc FC.MillisecondsShort) | ||
| instance rdi21 ∷ PrintFormatI rest ⇒ PrintFormatI (MillisecondsTwoDigits : rest) where printFormatI _ acc = printFormatI (FProxy ∷ FProxy rest) (flip Cons acc FC.MillisecondsTwoDigits) |
There was a problem hiding this comment.
No need to flip these 😄. Plus you can compose I think:
printFormatI _ = printFormatI (FProxy ∷ FProxy rest) <<< Cons FC.YearFulletc.
There was a problem hiding this comment.
It was late when i did that :d
There was a problem hiding this comment.
I'm not sure we necessarily need all the checks here, we mainly are trying to prevent broken/ambiguous formats, not stupid ones that have duplicate minutes or something. Just thinking about that as every check we add slows down the compilation time!
For stupid formats one could just build value level list and wrap in Unsafe.x.Format
Is it, that big of an issue?
I think we should also add such checks for values. like in case someone wants to validate dynamic format entered by a user.
| ) ⇒ ValidDate a | ||
|
|
||
| class ValidDateI (a ∷ FormatList) | ||
| instance vdi ∷ ValidDateI a |
There was a problem hiding this comment.
I have not implemented it date staff yet.
Here needs to go minute and seccond like checks for year month ....
| , ValidSecondsType secondsOut | ||
| , ValidateMilliseconds a NoMilliseconds millisecondsOut | ||
| , ValidMillisecondsType millisecondsOut | ||
| ) ⇒ ValidTimeI a |
| instance rdi18 ∷ PrintFormatI rest ⇒ PrintFormatI (SecondsTwoDigits : rest) where printFormatI _ acc = printFormatI (FProxy ∷ FProxy rest) (flip Cons acc FC.SecondsTwoDigits) | ||
| instance rdi19 ∷ PrintFormatI rest ⇒ PrintFormatI (Milliseconds : rest) where printFormatI _ acc = printFormatI (FProxy ∷ FProxy rest) (flip Cons acc FC.Milliseconds) | ||
| instance rdi20 ∷ PrintFormatI rest ⇒ PrintFormatI (MillisecondsShort : rest) where printFormatI _ acc = printFormatI (FProxy ∷ FProxy rest) (flip Cons acc FC.MillisecondsShort) | ||
| instance rdi21 ∷ PrintFormatI rest ⇒ PrintFormatI (MillisecondsTwoDigits : rest) where printFormatI _ acc = printFormatI (FProxy ∷ FProxy rest) (flip Cons acc FC.MillisecondsTwoDigits) |
There was a problem hiding this comment.
It was late when i did that :d
|
@cryogenian example: type MyFormat = MonthShort : YearFull : DayOfMonthTwoDigits : FNil
myFormat :: Formatter
myFormat = printFormat (FProxy :: FProxy MyFormat) |
|
Typelevel checks are done at this point, except TODO:
|
|
I don't think this really adds anything to this repo. Closing. |
|
From previous discussion I think it's clear that:
Even if this pr was total crap, "Closing due to lack of activity" would have been more accurate as well as respectful reason for closing. |
|
Sorry, @safareli, you’re completely right that that is a more accurate and respectful reason to close this. I would guess that @JordanMartinez was in a hurry as he’s working on a bunch of libraries at the same time right now and didn’t think about how those words would come across. Thank you for raising an objection, as we do want to make sure past, current, and future contributors feel respected. |
|
|
|
@safareli I'm very sorry. My tone was completely disrespectful. I didn't take the time to really understand what this PR was trying to solve. Yes, it would have been better to say that I was closing this due to inactivity. For context, we have 237 open PRs across core, contrib, web, and node libraries. I was doing a quick check to see where the state of such PRs were. If the changes were small and I could finish them, then I would. Otherwise, my default was to close them because nothing had been done for a long time. |
|
I'm not actively doing PS any more (for now), so this could be closed. (if anyone is up for taking this on they can just checkout from this branch or copy paste code) |
fix #22