Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization #85

Open
CarstenKoenig opened this issue Feb 8, 2023 · 2 comments
Open

Localization #85

CarstenKoenig opened this issue Feb 8, 2023 · 2 comments

Comments

@CarstenKoenig
Copy link
Contributor

CarstenKoenig commented Feb 8, 2023

Hi,

I'm actually not sure if this is an issue at all (meaning if there is not already a workaround I don't see - if so sorry) - but here we go:

I happen to write apps mainly for German speaking folks and here it's not 1,123.45 it's 1.123,45 (yeah stupid but hey 🤷).
It's not really a big deal as some simple replacing afterwards fixes this but still folks might be interested in having this in the library.

Proposed solution
I think having optional parameters for the thousand- and decimal-separator-characters defaulting to those here for the number-Formatter might be a good start.

I'd happily volunteer to implement such a change if you are interested in it.

What do you think?

@garyb
Copy link
Member

garyb commented Feb 8, 2023

Sounds good to me 👍

@CarstenKoenig
Copy link
Contributor Author

all right - I'll give it a try - thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants