-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to spago@next #148
base: main
Are you sure you want to change the base?
Conversation
9335af6
to
0886940
Compare
spago.yaml
Outdated
workspace: | ||
extraPackages: {} | ||
packageSet: | ||
registry: 60.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Libraries should not use package sets at all:
workspace: | |
extraPackages: {} | |
packageSet: | |
registry: 60.5.0 | |
workspace: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some errors
Reading Spago workspace configuration...
✓ Selecting package to build: affjax-node
✘ Could not solve the package dependencies, errors:
While solving affjax each version could not be solved:
- 13.0.0:
Conflict in version ranges for aff:
>=8.0.0 (declared dependency)
<8.0.0 seen in [email protected]
✓ Selecting package to build: aff-bus
✘ Could not solve the package dependencies, errors:
While solving avar each version could not be solved:
- 5.0.0:
Conflict in version ranges for aff:
>=8.0.0 (declared dependency)
<8.0.0 seen in [email protected]
✓ Selecting package to build: optparse
✘ Could not solve the package dependencies, errors:
No versions found in the registry for optparse in range
>=5.0.1 seen in [email protected], [email protected], [email protected]
<6.0.0 seen in [email protected], [email protected], [email protected]
✓ Selecting package to build: github-actions-toolkit
✘ Could not solve the package dependencies, errors:
While solving aff-promise each version could not be solved:
- 4.0.0:
Conflict in version ranges for aff:
>=8.0.0 (declared dependency)
<8.0.0 seen in [email protected]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's weird. I deleted the existing lockfile, added version ranges to the dependencies, and it appears to be working for me. Here's the diff:
diff --git a/spago.yaml b/spago.yaml
index 571b4f5..2055703 100644
--- a/spago.yaml
+++ b/spago.yaml
@@ -31,6 +31,7 @@ package:
test:
main: Test.Main
dependencies:
- - assert
- - effect
+ - assert: ">=6.0.0 <7.0.0"
+ - effect: ">=4.0.0 <5.0.0"
+
workspace: {}
and of the resulting lockfile change:
diff --git a/spago.lock b/spago.lock
index 2b03085..208e19d 100644
--- a/spago.lock
+++ b/spago.lock
@@ -112,8 +112,12 @@
},
"test": {
"dependencies": [
- "assert",
- "effect"
+ {
+ "assert": ">=6.0.0 <7.0.0"
+ },
+ {
+ "effect": ">=4.0.0 <5.0.0"
+ }
],
"build_plan": [
"assert",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I see you already were able to fix it.
Description of the change
Clearly and concisely describe the purpose of the pull request. If this PR relates to an existing issue or change proposal, please link to it. Include any other background context that would help reviewers understand the motivation for this PR.
Checklist: