From b46a92f80b814a9128b9f690ab93eb72fd5213f3 Mon Sep 17 00:00:00 2001 From: Janiss Binder Date: Mon, 28 Oct 2024 15:43:54 +0100 Subject: [PATCH] Add support for Rails 7.2 --- Appraisals | 12 ++++++++++++ README.md | 4 ++-- gemfiles/rails_7_2.gemfile | 17 +++++++++++++++++ puzzle-apartment.gemspec | 2 +- 4 files changed, 32 insertions(+), 3 deletions(-) create mode 100644 gemfiles/rails_7_2.gemfile diff --git a/Appraisals b/Appraisals index 990aa234..3e19a2fd 100644 --- a/Appraisals +++ b/Appraisals @@ -36,6 +36,18 @@ appraise 'rails-7-1' do end end +appraise 'rails-7-2' do + gem 'rails', '~> 7.2.0' + platforms :ruby do + gem 'sqlite3', '~> 1.6' + end + platforms :jruby do + gem 'activerecord-jdbc-adapter', '~> 61.0' + gem 'activerecord-jdbcpostgresql-adapter', '~> 61.0' + gem 'activerecord-jdbcmysql-adapter', '~> 61.0' + end +end + appraise 'rails-master' do gem 'rails', git: 'https://github.com/rails/rails.git' platforms :ruby do diff --git a/README.md b/README.md index 0d4614fc..0639b9e7 100644 --- a/README.md +++ b/README.md @@ -14,8 +14,8 @@ Nor the orginal [apartment](https://github.com/influitive/apartment) gem nor the Rails 6 for by [ros-apartment](https://github.com/rails-on-services/apartment) are maintained anymore. -Since we wanted to upgrade our application to Rails 7.1 we decided to fork -and start some development to support Rails 7.1. Because we don't have access +Since we wanted to upgrade our application to Rails 7.2 we decided to fork +and start some development to support Rails 7.2. Because we don't have access to the apartment gem itself, the solution was to release it under a different name but providing the exact same API as it was before. diff --git a/gemfiles/rails_7_2.gemfile b/gemfiles/rails_7_2.gemfile new file mode 100644 index 00000000..29421994 --- /dev/null +++ b/gemfiles/rails_7_2.gemfile @@ -0,0 +1,17 @@ +# This file was generated by Appraisal + +source "http://rubygems.org" + +gem "rails", "~> 7.2.0" + +platforms :ruby do + gem "sqlite3", "~> 1.6" +end + +platforms :jruby do + gem "activerecord-jdbc-adapter", "~> 61.0" + gem "activerecord-jdbcpostgresql-adapter", "~> 61.0" + gem "activerecord-jdbcmysql-adapter", "~> 61.0" +end + +gemspec path: "../" diff --git a/puzzle-apartment.gemspec b/puzzle-apartment.gemspec index 2ea9fd36..d5a18d12 100644 --- a/puzzle-apartment.gemspec +++ b/puzzle-apartment.gemspec @@ -27,7 +27,7 @@ Gem::Specification.new do |s| s.homepage = 'https://github.com/puzzle/apartment' s.licenses = ['MIT'] - s.add_dependency 'activerecord', '>= 6.1.0', '< 7.2' + s.add_dependency 'activerecord', '>= 6.1.0', '< 7.3' s.add_dependency 'parallel', '>= 1.10' s.add_dependency 'public_suffix', '>= 2.0.5' s.add_dependency 'rack', '>= 1.3.6'