Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor argument parsing #22

Open
carlbalmer opened this issue Oct 22, 2020 · 1 comment
Open

Refactor argument parsing #22

carlbalmer opened this issue Oct 22, 2020 · 1 comment
Assignees

Comments

@carlbalmer
Copy link
Contributor

Some steps use Util.parseArgs and others use ctx.stepParams.getRequired.

@carlbalmer carlbalmer self-assigned this Oct 22, 2020
@chrira
Copy link
Member

chrira commented Dec 3, 2020

Behavior is not the same for a missing required parameter.

IllegalArgumentException is thrown for Util.parseArgs

ctx.stepParams.getRequired calls error('Build failed')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants