diff --git a/backend/src/test/java/ch/puzzle/okr/service/business/KeyResultBusinessServiceTest.java b/backend/src/test/java/ch/puzzle/okr/service/business/KeyResultBusinessServiceTest.java index b81e79f4ed..6c635de6ed 100644 --- a/backend/src/test/java/ch/puzzle/okr/service/business/KeyResultBusinessServiceTest.java +++ b/backend/src/test/java/ch/puzzle/okr/service/business/KeyResultBusinessServiceTest.java @@ -71,10 +71,8 @@ void setup() { .withTitle("Keyresult Metric") .withObjective(objective) - .withOwner(user) - .withCreatedBy(user) .build(); ordinalKeyResult = KeyResultOrdinal.Builder diff --git a/backend/src/test/java/ch/puzzle/okr/service/validation/ActionValidationServiceTest.java b/backend/src/test/java/ch/puzzle/okr/service/validation/ActionValidationServiceTest.java index 1082fb365a..2482ec4f2d 100644 --- a/backend/src/test/java/ch/puzzle/okr/service/validation/ActionValidationServiceTest.java +++ b/backend/src/test/java/ch/puzzle/okr/service/validation/ActionValidationServiceTest.java @@ -403,11 +403,7 @@ void shouldThrowExceptionOnValidateOnUpdateWhenKeyResultIsMissing() { @Test void shouldThrowExceptionOnValidateOnUpdateWhenAttrsAreMissing() { // arrange - Action actionInvalid = Action.Builder - .builder() - .withId(11L) - .isChecked(true) - .withKeyResult(keyResult).build(); + Action actionInvalid = Action.Builder.builder().withId(11L).isChecked(true).withKeyResult(keyResult).build(); when(actionPersistenceService.findById(anyLong())).thenReturn(actionInvalid); // act + assert diff --git a/backend/src/test/java/ch/puzzle/okr/service/validation/UserValidationServiceTest.java b/backend/src/test/java/ch/puzzle/okr/service/validation/UserValidationServiceTest.java index 0ba89043dd..6a69a13292 100644 --- a/backend/src/test/java/ch/puzzle/okr/service/validation/UserValidationServiceTest.java +++ b/backend/src/test/java/ch/puzzle/okr/service/validation/UserValidationServiceTest.java @@ -268,11 +268,7 @@ void validateOnCreateShouldThrowExceptionWhenLastnameIsInvalid(String name, List @ParameterizedTest(name = "should throw exception on validateCreate() when model has invalid email '{0}'") @MethodSource("emailValidationArguments") void validateOnCreateShouldThrowExceptionWhenEmailIsInvalid(String email, List errors) { - User user = User.Builder - .builder() - .withEmail(email) - .withFirstName("firstname") - .withLastName("lastname").build(); + User user = User.Builder.builder().withEmail(email).withFirstName("firstname").withLastName("lastname").build(); OkrResponseStatusException exception = assertThrows(OkrResponseStatusException.class, () -> validator.validateOnCreate(user)); diff --git a/backend/src/test/java/ch/puzzle/okr/util/quarter/generate/QuarterLabelTest.java b/backend/src/test/java/ch/puzzle/okr/util/quarter/generate/QuarterLabelTest.java index e48ac9e5de..b5b522b355 100644 --- a/backend/src/test/java/ch/puzzle/okr/util/quarter/generate/QuarterLabelTest.java +++ b/backend/src/test/java/ch/puzzle/okr/util/quarter/generate/QuarterLabelTest.java @@ -2,10 +2,6 @@ import static org.junit.jupiter.api.Assertions.*; -import java.time.LocalDate; -import java.util.stream.Stream; -import static org.junit.jupiter.api.Assertions.*; - import java.time.LocalDate; import java.util.stream.Stream; import org.junit.jupiter.params.ParameterizedTest; diff --git a/frontend/src/app/components/check-in-history-dialog/check-in-history-dialog.component.ts b/frontend/src/app/components/check-in-history-dialog/check-in-history-dialog.component.ts index cd87d2b99e..9ccea9d58b 100644 --- a/frontend/src/app/components/check-in-history-dialog/check-in-history-dialog.component.ts +++ b/frontend/src/app/components/check-in-history-dialog/check-in-history-dialog.component.ts @@ -14,7 +14,7 @@ import { CheckInOrdinalMin } from '../../shared/types/model/CheckInOrdinalMin'; @Component({ selector: 'app-check-in-history-dialog', - templateUrl: './check-in-history-dialog.component.html', + templateUrl: './check-in-history-dialog.component.html' }) export class CheckInHistoryDialogComponent implements OnInit { keyResult!: KeyResult; diff --git a/frontend/src/app/components/key-result-type/key-result-type.component.ts b/frontend/src/app/components/key-result-type/key-result-type.component.ts index 4413330d83..3c143d8a71 100644 --- a/frontend/src/app/components/key-result-type/key-result-type.component.ts +++ b/frontend/src/app/components/key-result-type/key-result-type.component.ts @@ -16,6 +16,7 @@ export class KeyResultTypeComponent implements OnInit { @Input() keyResultForm!: FormGroup; @Input() keyResult!: KeyResult | null; + @Output() formValidityEmitter = new EventEmitter(); isMetric = true; diff --git a/frontend/src/style/custom_bootstrap.scss b/frontend/src/style/custom_bootstrap.scss index 74f27119b9..ec230cb903 100644 --- a/frontend/src/style/custom_bootstrap.scss +++ b/frontend/src/style/custom_bootstrap.scss @@ -1,10 +1,10 @@ @import '_variables'; $theme-colors: ( - "pz-dark-blue": $pz-dark-blue, - "eggshell": $eggshell, - "display-element": $display-element, - "key-result-attribute": $key-result-attribute-bg, - "error": $error, + 'pz-dark-blue': $pz-dark-blue, + 'eggshell': $eggshell, + 'display-element': $display-element, + 'key-result-attribute': $key-result-attribute-bg, + 'error': $error, ); $enable-negative-margins: true; @import 'bootstrap'; diff --git a/frontend/src/style/styles.scss b/frontend/src/style/styles.scss index 10f434bfa0..20a2d37374 100644 --- a/frontend/src/style/styles.scss +++ b/frontend/src/style/styles.scss @@ -261,8 +261,8 @@ mat-form-field.quarter-filter .mat-mdc-text-field-wrapper { } .sub-title-key-result { - font-family: Roboto, "sans-serif"; - font-variation-settings: "wght" 400; + font-family: Roboto, 'sans-serif'; + font-variation-settings: 'wght' 400; font-size: 0.9rem !important; }