From 6091faeca097cec0e6615520cb5da1b1b9502ffe Mon Sep 17 00:00:00 2001
From: Jannik Pulfer <pulfer@puzzle.ch>
Date: Fri, 15 Nov 2024 15:58:10 +0100
Subject: [PATCH] Fix wrong test name and remove redundant page visits from
 tests

---
 frontend/cypress/e2e/checkIn.cy.ts            | 1 -
 frontend/cypress/e2e/crud.cy.ts               | 1 -
 frontend/cypress/e2e/duplicated-scoring.cy.ts | 3 +--
 frontend/cypress/e2e/keyresult.cy.ts          | 1 -
 frontend/cypress/e2e/objective-backlog.cy.ts  | 1 -
 frontend/cypress/e2e/objective.cy.ts          | 1 -
 frontend/cypress/e2e/routing.cy.ts            | 1 -
 frontend/cypress/e2e/scoring.cy.ts            | 1 -
 frontend/cypress/e2e/tab.cy.ts                | 1 -
 9 files changed, 1 insertion(+), 10 deletions(-)

diff --git a/frontend/cypress/e2e/checkIn.cy.ts b/frontend/cypress/e2e/checkIn.cy.ts
index 005473fe6f..a6c25da631 100644
--- a/frontend/cypress/e2e/checkIn.cy.ts
+++ b/frontend/cypress/e2e/checkIn.cy.ts
@@ -17,7 +17,6 @@ describe('OKR Check-in e2e tests', () => {
       op = new CyOverviewPage();
       keyresultDetailPage = new KeyresultDetailPage();
       cy.loginAsUser(users.gl);
-      op.visitCurrentQuarter();
       onlyOn('chrome');
     });
 
diff --git a/frontend/cypress/e2e/crud.cy.ts b/frontend/cypress/e2e/crud.cy.ts
index 32b945df3e..790591f10e 100644
--- a/frontend/cypress/e2e/crud.cy.ts
+++ b/frontend/cypress/e2e/crud.cy.ts
@@ -8,7 +8,6 @@ describe('CRUD operations', () => {
   beforeEach(() => {
     op = new CyOverviewPage();
     cy.loginAsUser(users.gl);
-    cy.visit('/?quarter=2');
   });
 
   [
diff --git a/frontend/cypress/e2e/duplicated-scoring.cy.ts b/frontend/cypress/e2e/duplicated-scoring.cy.ts
index 7ee79ab919..bab3ca3193 100644
--- a/frontend/cypress/e2e/duplicated-scoring.cy.ts
+++ b/frontend/cypress/e2e/duplicated-scoring.cy.ts
@@ -11,11 +11,10 @@ describe('e2e test for scoring adjustment on objective duplicate', () => {
     op = new CyOverviewPage();
     keyresultDetailPage = new KeyresultDetailPage();
     cy.loginAsUser(users.gl);
-    op.visitCurrentQuarter();
     onlyOn('chrome');
   });
 
-  it('Create ordinal checkin and validate value of scoring component', () => {
+  it('Duplicate ordinal checkin and validate value of scoring component', () => {
     op.addKeyresult('Puzzle ITC', 'Wir wollen die Kundenzufriedenheit steigern')
       .fillKeyresultTitle('stretch keyresult for testing')
       .withOrdinalValues('Ex. val', 'Ex. val', 'Ex. val')
diff --git a/frontend/cypress/e2e/keyresult.cy.ts b/frontend/cypress/e2e/keyresult.cy.ts
index 09ba19c3e4..4251371ff6 100644
--- a/frontend/cypress/e2e/keyresult.cy.ts
+++ b/frontend/cypress/e2e/keyresult.cy.ts
@@ -12,7 +12,6 @@ describe('OKR Overview', () => {
     op = new CyOverviewPage();
     keyresultDetailPage = new KeyresultDetailPage();
     cy.loginAsUser(users.gl);
-    cy.visit('/?quarter=2');
   });
 
   it('Create new metric KeyResult', () => {
diff --git a/frontend/cypress/e2e/objective-backlog.cy.ts b/frontend/cypress/e2e/objective-backlog.cy.ts
index 464ddf4e26..22fd051ef6 100644
--- a/frontend/cypress/e2e/objective-backlog.cy.ts
+++ b/frontend/cypress/e2e/objective-backlog.cy.ts
@@ -8,7 +8,6 @@ describe('OKR Objective Backlog e2e tests', () => {
   beforeEach(() => {
     op = new CyOverviewPage();
     cy.loginAsUser(users.gl);
-    op.visitCurrentQuarter();
   });
 
   it(`Create Objective in backlog quarter should not have save button`, () => {
diff --git a/frontend/cypress/e2e/objective.cy.ts b/frontend/cypress/e2e/objective.cy.ts
index 34913bc746..ad0d351f06 100644
--- a/frontend/cypress/e2e/objective.cy.ts
+++ b/frontend/cypress/e2e/objective.cy.ts
@@ -9,7 +9,6 @@ describe('OKR Objective e2e tests', () => {
   beforeEach(() => {
     op = new CyOverviewPage();
     cy.loginAsUser(users.gl);
-    op.visitCurrentQuarter();
   });
 
   describe('tests via click', () => {
diff --git a/frontend/cypress/e2e/routing.cy.ts b/frontend/cypress/e2e/routing.cy.ts
index 282366b894..0667609b11 100644
--- a/frontend/cypress/e2e/routing.cy.ts
+++ b/frontend/cypress/e2e/routing.cy.ts
@@ -5,7 +5,6 @@ import TeammanagementPage from '../support/helper/pom-helper/pages/teammanagemen
 describe('Routing', () => {
   beforeEach(() => {
     cy.loginAsUser(users.gl);
-    cy.visit('');
   });
 
   describe('Route via url', () => {
diff --git a/frontend/cypress/e2e/scoring.cy.ts b/frontend/cypress/e2e/scoring.cy.ts
index 271cbceb88..6ed994a56c 100644
--- a/frontend/cypress/e2e/scoring.cy.ts
+++ b/frontend/cypress/e2e/scoring.cy.ts
@@ -14,7 +14,6 @@ describe('Scoring component e2e tests', () => {
     keyresultDetailPage = new KeyresultDetailPage();
     cy.loginAsUser(users.gl);
     onlyOn('chrome');
-    cy.visit('/?quarter=2');
   });
 
   [
diff --git a/frontend/cypress/e2e/tab.cy.ts b/frontend/cypress/e2e/tab.cy.ts
index c7d700b661..3e835e6b34 100644
--- a/frontend/cypress/e2e/tab.cy.ts
+++ b/frontend/cypress/e2e/tab.cy.ts
@@ -10,7 +10,6 @@ describe('Tab workflow tests', () => {
     onlyOn('chrome');
     cy.loginAsUser(users.gl);
     overviewPage = new CyOverviewPage();
-    overviewPage.visitCurrentQuarter();
     overviewPage.elements.logo().parent().focus();
   });