From 643258bd346af17608fa0a413bbd04b1bad4d121 Mon Sep 17 00:00:00 2001 From: Nevio Di Gennaro Date: Tue, 24 Dec 2024 11:27:39 +0100 Subject: [PATCH] fix formatting errors --- frontend/cypress/e2e/team-management.cy.ts | 2 +- .../app/components/confidence/confidence.component.spec.ts | 4 ---- .../components/key-result-form/key-result-form.component.ts | 4 +++- frontend/src/app/shared/side-panel/side-panel.component.ts | 5 +---- 4 files changed, 5 insertions(+), 10 deletions(-) diff --git a/frontend/cypress/e2e/team-management.cy.ts b/frontend/cypress/e2e/team-management.cy.ts index a20c961b85..8f2333955a 100644 --- a/frontend/cypress/e2e/team-management.cy.ts +++ b/frontend/cypress/e2e/team-management.cy.ts @@ -304,7 +304,7 @@ describe('okr team-management', () => { return true; }) .then(() => { - expect(foundEsha).to.be.true; + expect(foundEsha).to.equal(true); }); }); diff --git a/frontend/src/app/components/confidence/confidence.component.spec.ts b/frontend/src/app/components/confidence/confidence.component.spec.ts index 583ebd8b0f..a628972571 100644 --- a/frontend/src/app/components/confidence/confidence.component.spec.ts +++ b/frontend/src/app/components/confidence/confidence.component.spec.ts @@ -1,8 +1,6 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; import { ConfidenceComponent } from './confidence.component'; -import { HarnessLoader } from '@angular/cdk/testing'; -import { TestbedHarnessEnvironment } from '@angular/cdk/testing/testbed'; import { checkInMetric } from '../../shared/testData'; import { MatSliderModule } from '@angular/material/slider'; import { CheckInMin } from '../../shared/types/model/CheckInMin'; @@ -13,7 +11,6 @@ import { By } from '@angular/platform-browser'; describe('ConfidenceComponent', () => { let component: ConfidenceComponent; let fixture: ComponentFixture; - let loader: HarnessLoader; beforeEach(() => { TestBed.configureTestingModule({ @@ -25,7 +22,6 @@ describe('ConfidenceComponent', () => { fixture = TestBed.createComponent(ConfidenceComponent); component = fixture.componentInstance; - loader = TestbedHarnessEnvironment.loader(fixture); component.checkIn = checkInMetric; component.isEdit = true; }); diff --git a/frontend/src/app/components/key-result-form/key-result-form.component.ts b/frontend/src/app/components/key-result-form/key-result-form.component.ts index 40c87ce96d..6f88e55fef 100644 --- a/frontend/src/app/components/key-result-form/key-result-form.component.ts +++ b/frontend/src/app/components/key-result-form/key-result-form.component.ts @@ -143,7 +143,9 @@ export class KeyResultFormComponent implements OnInit, OnDestroy { return this.keyResult ? this.keyResult.id : null; } - updateFormValidity() {} + updateFormValidity() { + // Implemented because of interface this comment is to satisfy the linter + } getFullNameOfLoggedInUser() { return this.getFullNameOfUser(this.userService.getCurrentUser()); diff --git a/frontend/src/app/shared/side-panel/side-panel.component.ts b/frontend/src/app/shared/side-panel/side-panel.component.ts index 5f0d4d353e..4f71c5d5db 100644 --- a/frontend/src/app/shared/side-panel/side-panel.component.ts +++ b/frontend/src/app/shared/side-panel/side-panel.component.ts @@ -5,7 +5,6 @@ import { Component, ElementRef, OnDestroy, - OnInit, ViewChild } from '@angular/core'; import { ActivatedRoute, Router } from '@angular/router'; @@ -17,7 +16,7 @@ import { ConnectedPosition } from '@angular/cdk/overlay'; // ESM styleUrls: ['./side-panel.component.scss'], changeDetection: ChangeDetectionStrategy.OnPush }) -export class SidePanelComponent implements OnInit, AfterContentInit, OnDestroy { +export class SidePanelComponent implements AfterContentInit, OnDestroy { leaveKeys = ['Escape']; right = '-100%'; @@ -38,8 +37,6 @@ export class SidePanelComponent implements OnInit, AfterContentInit, OnDestroy { private cd: ChangeDetectorRef, private route: ActivatedRoute) {} - ngOnInit(): void {} - ngAfterContentInit(): void { document.body.classList.add('disable-scrolling'); this.right = '0';