From 7173ca9736b0bcd0a413ffea7e729d94b8d805eb Mon Sep 17 00:00:00 2001
From: Nevio Di Gennaro <digennaro@puzzle.ch>
Date: Tue, 10 Dec 2024 11:40:06 +0100
Subject: [PATCH] remove the this from all variables/functions inside templates
 because its deprecated

---
 .../action-plan/action-plan.component.html       |  2 +-
 .../application-top-bar.component.html           | 11 ++---------
 .../check-in-form/check-in-form.component.html   |  2 +-
 .../keyresult-dialog.component.html              |  2 +-
 .../components/overview/overview.component.html  |  2 +-
 .../team-filter/team-filter.component.html       |  2 +-
 .../okr-tangram/okr-tangram.component.html       |  2 +-
 .../confirm-dialog/confirm-dialog.component.html | 16 ++++++++--------
 .../objective-form.component.html                |  2 +-
 .../delete-user/delete-user.component.html       |  2 +-
 10 files changed, 18 insertions(+), 25 deletions(-)

diff --git a/frontend/src/app/components/action-plan/action-plan.component.html b/frontend/src/app/components/action-plan/action-plan.component.html
index 68388cea32..b753bf3b22 100644
--- a/frontend/src/app/components/action-plan/action-plan.component.html
+++ b/frontend/src/app/components/action-plan/action-plan.component.html
@@ -24,7 +24,7 @@
         (keydown.arrowDown)="handleKeyDown($event, i)"
         (keydown.arrowUp)="handleKeyDown($event, i)"
         (focusin)="activeItem = i"
-        (input)="updateActionTexts(this.control.value!)"
+        (input)="updateActionTexts(control.value!)"
         class="action-input"
         [value]="action.action"
         [attr.data-testId]="'actionInput'"
diff --git a/frontend/src/app/components/application-top-bar/application-top-bar.component.html b/frontend/src/app/components/application-top-bar/application-top-bar.component.html
index 4d764f97ea..024dc58fc3 100644
--- a/frontend/src/app/components/application-top-bar/application-top-bar.component.html
+++ b/frontend/src/app/components/application-top-bar/application-top-bar.component.html
@@ -1,14 +1,7 @@
 <div id="topBarHeight">
   <div id="okrTopbar">
     <a routerLink="/" queryParamsHandling="preserve" class="d-flex h-100 align-items-center ps-4">
-      <img
-        [attr.data-testId]="'logo'"
-        alt="okr-logo"
-        height="32"
-        ngSrc="{{ this.logoSrc$ | async }}"
-        width="140"
-        priority
-      />
+      <img [attr.data-testId]="'logo'" alt="okr-logo" height="32" ngSrc="{{ logoSrc$ | async }}" width="140" priority />
     </a>
     <div class="d-flex align-items-center me-md-5 me-1">
       <button
@@ -22,7 +15,7 @@
       </button>
 
       <button
-        *ngIf="this.helpSiteUrl | async as helpSiteUrl"
+        *ngIf="helpSiteUrl | async as helpSiteUrl"
         id="hilfeButton"
         class="topBarEntry btn"
         [attr.data-testId]="'help-button'"
diff --git a/frontend/src/app/components/checkin/check-in-form/check-in-form.component.html b/frontend/src/app/components/checkin/check-in-form/check-in-form.component.html
index 1ef7d4846f..bcf1df0a80 100644
--- a/frontend/src/app/components/checkin/check-in-form/check-in-form.component.html
+++ b/frontend/src/app/components/checkin/check-in-form/check-in-form.component.html
@@ -89,7 +89,7 @@ <h3 class="okr-form-label okr-form-col">Key Result</h3>
       <button
         (click)="saveCheckIn()"
         [attr.data-testId]="'submit-check-in'"
-        [disabled]="!this.dialogForm.valid"
+        [disabled]="!dialogForm.valid"
         color="primary"
         mat-flat-button
         type="submit"
diff --git a/frontend/src/app/components/keyresult-dialog/keyresult-dialog.component.html b/frontend/src/app/components/keyresult-dialog/keyresult-dialog.component.html
index 3928683745..3afc85c4b8 100644
--- a/frontend/src/app/components/keyresult-dialog/keyresult-dialog.component.html
+++ b/frontend/src/app/components/keyresult-dialog/keyresult-dialog.component.html
@@ -26,7 +26,7 @@
       </button>
       <button mat-button mat-dialog-close color="primary" [attr.data-testId]="'cancel'">Abbrechen</button>
     </div>
-    <div class="col-auto" *ngIf="this.data.keyResult">
+    <div class="col-auto" *ngIf="data.keyResult">
       <button color="primary" mat-button (click)="deleteKeyResult()" [attr.data-testId]="'delete-keyResult'">
         Key Result löschen
       </button>
diff --git a/frontend/src/app/components/overview/overview.component.html b/frontend/src/app/components/overview/overview.component.html
index 7103ade284..e56d87ded4 100644
--- a/frontend/src/app/components/overview/overview.component.html
+++ b/frontend/src/app/components/overview/overview.component.html
@@ -7,7 +7,7 @@
   </app-team>
   <div *ngIf="(overviewEntities$ | async)?.length == 0" class="d-flex align-items-center flex-column pt-5 gap-5">
     <p>Kein Team ausgewählt</p>
-    <img src="{{ this.backgroundLogoSrc$ | async }}" alt="Greyed out company logo" width="242" class="puzzle-logo" />
+    <img src="{{ backgroundLogoSrc$ | async }}" alt="Greyed out company logo" width="242" class="puzzle-logo" />
   </div>
 </div>
 <router-outlet></router-outlet>
diff --git a/frontend/src/app/components/team-filter/team-filter.component.html b/frontend/src/app/components/team-filter/team-filter.component.html
index 25c9aa1bcc..2ad52e435f 100644
--- a/frontend/src/app/components/team-filter/team-filter.component.html
+++ b/frontend/src/app/components/team-filter/team-filter.component.html
@@ -2,7 +2,7 @@
   <button (click)="toggleAll()" class="icon-button focus-outline mt-1 me-1">
     <mat-chip
       [attr.data-testId]="'team-filter-alle'"
-      [highlighted]="activeTeams.length == (this.teams$ | async)?.length"
+      [highlighted]="activeTeams.length == (teams$ | async)?.length"
       color="primary"
     >
       <p>Alle</p>
diff --git a/frontend/src/app/shared/custom/okr-tangram/okr-tangram.component.html b/frontend/src/app/shared/custom/okr-tangram/okr-tangram.component.html
index 92bb32f252..63d96dc832 100644
--- a/frontend/src/app/shared/custom/okr-tangram/okr-tangram.component.html
+++ b/frontend/src/app/shared/custom/okr-tangram/okr-tangram.component.html
@@ -1 +1 @@
-<img alt="okr-logo" ngSrc="{{ this.trianglesSrc$ | async }}" width="274" height="140" priority />
+<img alt="okr-logo" ngSrc="{{ trianglesSrc$ | async }}" width="274" height="140" priority />
diff --git a/frontend/src/app/shared/dialog/confirm-dialog/confirm-dialog.component.html b/frontend/src/app/shared/dialog/confirm-dialog/confirm-dialog.component.html
index 04efba3d85..45d604b091 100644
--- a/frontend/src/app/shared/dialog/confirm-dialog/confirm-dialog.component.html
+++ b/frontend/src/app/shared/dialog/confirm-dialog/confirm-dialog.component.html
@@ -1,18 +1,18 @@
 <app-dialog-template-core [title]="dialogTitle">
   <ng-container content>
     <div class="linebreak bg-display-element p-2 fw-normal mb-3">
-      <span class="information">{{ this.dialogText.trim() }}</span>
+      <span class="information">{{ dialogText.trim() }}</span>
     </div>
   </ng-container>
 
   <ng-container actions>
     <div class="col-auto">
       <button
-        *ngIf="this.isYesButtonVisible()"
-        [disabled]="this.isYesButtonDisabled()"
+        *ngIf="isYesButtonVisible()"
+        [disabled]="isYesButtonDisabled()"
         [attr.data-testId]="'confirm-yes'"
         type="submit"
-        (click)="this.closeAndDelete()"
+        (click)="closeAndDelete()"
         color="primary"
         mat-flat-button
       >
@@ -20,8 +20,8 @@
       </button>
 
       <button
-        *ngIf="this.isNoButtonVisible()"
-        [disabled]="this.isNoButtonDisabled()"
+        *ngIf="isNoButtonVisible()"
+        [disabled]="isNoButtonDisabled()"
         mat-button
         mat-dialog-close
         color="primary"
@@ -30,8 +30,8 @@
         Nein
       </button>
       <button
-        *ngIf="this.isCloseButtonVisible()"
-        [disabled]="this.isCloseButtonDisabled()"
+        *ngIf="isCloseButtonVisible()"
+        [disabled]="isCloseButtonDisabled()"
         mat-button
         mat-dialog-close
         color="primary"
diff --git a/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html b/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html
index f6a1b30d0e..477230e9c0 100644
--- a/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html
+++ b/frontend/src/app/shared/dialog/objective-dialog/objective-form.component.html
@@ -1,4 +1,4 @@
-<app-dialog-template-core [title]="getDialogTitle((this.currentTeam | async)?.name || '')">
+<app-dialog-template-core [title]="getDialogTitle((currentTeam | async)?.name || '')">
   <ng-container content>
     <form [formGroup]="objectiveForm">
       <div class="okr-form-row okr-form-label-input-container">
diff --git a/frontend/src/app/team-management/delete-user/delete-user.component.html b/frontend/src/app/team-management/delete-user/delete-user.component.html
index 26686375f2..95cc0367a5 100644
--- a/frontend/src/app/team-management/delete-user/delete-user.component.html
+++ b/frontend/src/app/team-management/delete-user/delete-user.component.html
@@ -9,7 +9,7 @@
   >
     <span class="d-flex align-items-center fw-bold add-text">
       <img alt="Delete user button" class="add-cross-button" src="/assets/icons/delete-blue-icon.svg" />
-      {{ getFullNameFromUser(this.user) }} l&ouml;schen
+      {{ getFullNameFromUser(user) }} l&ouml;schen
     </span>
   </button>
 </ng-container>