From bd52b31270d1e1cc3de909c69e02558271b294c8 Mon Sep 17 00:00:00 2001
From: Manuel <moeri@puzzle.ch>
Date: Wed, 23 Oct 2024 15:09:59 +0200
Subject: [PATCH] Fix a couple semantic tags and format code

---
 .../components/confidence/confidence.component.html    |  2 +-
 .../complete-dialog/complete-dialog.component.html     | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/frontend/src/app/components/confidence/confidence.component.html b/frontend/src/app/components/confidence/confidence.component.html
index 5c779b40f9..36c0de0c95 100644
--- a/frontend/src/app/components/confidence/confidence.component.html
+++ b/frontend/src/app/components/confidence/confidence.component.html
@@ -7,7 +7,7 @@
     class="bg-inherit d-flex justify-content-center align-items-center"
     [ngClass]="[edit ? 'keyResult-attribute-edit' : 'keyResult-attribute-show', isDetail ? 'height' : '']"
   >
-    <span class="fw-normal text-black keyResult-overview-attribute" data-testid="confidence"
+    <span class="fw-normal text-black keyResult-overview-attribute" [attr.data-testId]="'confidence'"
       >{{ checkIn.confidence }}/{{ max }}</span
     >
   </div>
diff --git a/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.html b/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.html
index 6542961736..940efa3ca4 100644
--- a/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.html
+++ b/frontend/src/app/shared/dialog/complete-dialog/complete-dialog.component.html
@@ -11,9 +11,9 @@
 
     <form [formGroup]="completeForm">
       <div class="input-style gap-2 col-12">
-        <label class="text-black">Bewertung</label>
+        <p class="text-black">Bewertung</p>
         <div class="d-flex gap-3">
-          <span
+          <button
             class="successful w-50 valuation-card card-hover-successful"
             [ngClass]="{
               'active-successful': completeForm.value.isSuccessful == true,
@@ -25,8 +25,8 @@
             tabindex="0"
           >
             Objective erreicht
-          </span>
-          <span
+          </button>
+          <button
             class="not-successful w-50 valuation-card card-hover-not-successful"
             [ngClass]="{
               'active-not-successful': completeForm.value.isSuccessful === false,
@@ -38,7 +38,7 @@
             tabindex="0"
           >
             Objective nicht erreicht
-          </span>
+          </button>
         </div>
       </div>