Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Angular to 19 #1070

Open
peggimann opened this issue Oct 21, 2024 · 4 comments · May be fixed by #1241
Open

Update Angular to 19 #1070

peggimann opened this issue Oct 21, 2024 · 4 comments · May be fixed by #1241
Labels
blocked This ticket is blocked by another ticket
Milestone
UX Überarbeitung ...

Comments

@peggimann
Copy link
Collaborator

peggimann commented Oct 21, 2024 •
edited by kcinay055679
Loading

Update Angular auf version 19.

Caution

Currently @angular-devkit/build-angular can not be updated because of unmet peer deps in jest-preset-angular thus Angular > 19 can not yet be implemented!
keep track on https://github.com/thymikee/jest-preset-angular/blob/b415b97ec1467a1384951158ea421e94b7e8fd78/package.json#L60
neuer Release is in the making: https://github.com/thymikee/jest-preset-angular/blob/v14.4.0-rc.0/package.json

Update

New version of jest-preset-angular is released
@peggimann peggimann mentioned this issue Oct 21, 2024
Open
10 tasks
@nevio18324 nevio18324 self-assigned this Oct 24, 2024
@nevio18324 nevio18324 added blocked This ticket is blocked by another ticket To be discussed and removed blocked This ticket is blocked by another ticket labels Oct 24, 2024
@nevio18324
Copy link
Collaborator

Die Version ist noch nicht von Angular supported.
Man könnte Jedoch das umgehen, was aber zu anderen Problemen führen könnte.

@peggimann peggimann changed the title Update dependency typescript to v5.6.3 Update Angular to 19 Nov 22, 2024
@peggimann peggimann added blocked This ticket is blocked by another ticket and removed To be discussed labels Nov 22, 2024
@kcinay055679 kcinay055679 removed the blocked This ticket is blocked by another ticket label Nov 28, 2024
@peggimann peggimann mentioned this issue Nov 29, 2024
Closed
1 task
@nevio18324 nevio18324 self-assigned this Dec 9, 2024
@nevio18324
Copy link
Collaborator

nevio18324 commented Dec 9, 2024 •
edited
Loading

Todo's

  • Migration guide durchlesen
  • Angular Core und Cli updaten
  • alle anderen dependencies falls nötig z.B Angular Material
  • falls nötig devDependencies updaten
  • nach Deprecations schauen/lösen
    1. Alle scss @import zu @use ändern da @import deprecated ist
    2. Man kann nicht mehr globale variablen direkt aufrufen in scss heisst aus $top-bar-height -> variables.$top-bar-height
  • Das standart für standalone ist in der neuen Version true was bei uns nicht der Fall ist heisst bei allen component,pipes und directives standalone = false hinzufügen
  • Man soll beim variablen access im template nicht mehr this brauchen heisst z.B {{this.foo}} -> {{foo}} um änderen

@nevio18324 nevio18324 linked a pull request Dec 10, 2024 that will close this issue
Update Angular to 19 #1241
Draft
@nevio18324 nevio18324 reopened this Dec 10, 2024
@nevio18324
Copy link
Collaborator

Ausversehen geclosed

@nevio18324
Copy link
Collaborator

Blocked

Das Ticket wird geblocked da Jest 29.7.0 4 deprecated peer dependencies besitzt

npm warn deprecated [email protected]: This module is not supported, and leaks memory.
npm warn deprecated [email protected]: Use your platform's native atob() and btoa() methods instead
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Use your platform's native DOMException instead

Glob und inflight werden in Jest 30.0.6-alpha gelöst jedoch braucht angular-devkit/build-angular jest 29.7.0
Auf github gibt es schon mehrere issues über dieses Problem
jestjs/jest#15087
jestjs/jest#15236
jedoch scheint Jest dies erst in der Version 30 lösen zu wollen. Bis dahin müssen wir warten,

@nevio18324 nevio18324 added the blocked This ticket is blocked by another ticket label Dec 16, 2024
@nevio18324 nevio18324 removed their assignment Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This ticket is blocked by another ticket
Projects
None yet
Milestone
UX Überarbeitung und Bug Fixing
Development

Successfully merging a pull request may close this issue.

Update Angular to 19 puzzle/okr
3 participants
@kcinay055679 @peggimann @nevio18324