diff --git a/frontend/cypress/e2e/checkIn.cy.ts b/frontend/cypress/e2e/checkIn.cy.ts index 6335938413..b4a84a3fa9 100644 --- a/frontend/cypress/e2e/checkIn.cy.ts +++ b/frontend/cypress/e2e/checkIn.cy.ts @@ -173,7 +173,6 @@ describe('OKR Check-in e2e tests', () => { cy.contains('5/10'); cy.getByTestId('check-in-metric-value').clear().type('200'); cy.getByTestId('confidence-slider').realMouseDown(); - cy.getByTestId('check-in-next').click(); cy.contains('Here we are'); cy.contains('A cat would be great'); cy.getByTestId('changeInfo').clear().type('We bought a new sheep'); @@ -217,7 +216,6 @@ describe('OKR Check-in e2e tests', () => { cy.contains('6/10'); cy.getByTestId('stretch-radio').click(); cy.getByTestId('confidence-slider').realMouseDown(); - cy.getByTestId('check-in-next').click(); cy.contains('There is a new car'); cy.contains('Buy now a new pool'); cy.getByTestId('changeInfo').clear().type('We bought a new dog'); @@ -233,17 +231,16 @@ describe('OKR Check-in e2e tests', () => { function checkForDialogTextMetric() { cy.contains('Very important keyresult'); - cy.contains('Check-in erfassen (1/2)'); + cy.contains('Check-in erfassen'); cy.contains('Key Result'); cy.contains('Aktueller Wert'); cy.contains('Confidence um Target (42.7%) zu erreichen'); - cy.contains('Weiter'); cy.contains('Abbrechen'); } function checkForDialogTextOrdinal() { cy.contains('A new ordinal keyresult for our company'); - cy.contains('Check-in erfassen (1/2)'); + cy.contains('Check-in erfassen'); cy.contains('Key Result'); cy.contains('Zone (Commit / Target / Stretch) noch nicht erreicht '); cy.contains('Commit:'); @@ -253,7 +250,6 @@ function checkForDialogTextOrdinal() { cy.contains('New house'); cy.contains('New pool'); cy.contains('Confidence um Target zu erreichen'); - cy.contains('Weiter'); cy.contains('Abbrechen'); } diff --git a/frontend/cypress/e2e/scoring.cy.ts b/frontend/cypress/e2e/scoring.cy.ts index 2566485f31..aeaa7c25a5 100644 --- a/frontend/cypress/e2e/scoring.cy.ts +++ b/frontend/cypress/e2e/scoring.cy.ts @@ -22,10 +22,9 @@ describe('Scoring component e2e tests', () => { cy.getByTestId('key-result-metric-value').clear().type(String(value)); cy.getByTestId('confidence-slider').click(); cy.realPress('{rightarrow}').realPress('{rightarrow}').realPress('{rightarrow}'); - cy.getByTestId('check-in-next').click(); cy.getByTestId('changeInfo').click().type('Testveränderungen'); cy.getByTestId('initiatives').click().type('Testmassnahmen'); - cy.getByTestId('create-checkin').click(); + cy.getByTestId('submit-check-in').click(); const percentage = getPercentageMetric(baseline, stretchgoal, value); cy.validateScoring(false, percentage); cy.getByTestId('close-drawer').click(); @@ -41,10 +40,9 @@ describe('Scoring component e2e tests', () => { cy.getByTestId(`${zoneName}-radio`).click(); cy.getByTestId('confidence-slider').click(); cy.realPress('{rightarrow}').realPress('{rightarrow}').realPress('{rightarrow}'); - cy.getByTestId('check-in-next').click(); cy.getByTestId('changeInfo').click().type('Testveränderungen'); cy.getByTestId('initiatives').click().type('Testmassnahmen'); - cy.getByTestId('create-checkin').click(); + cy.getByTestId('submit-check-in').click(); const percentage = getPercentageOrdinal(zoneName); cy.validateScoring(false, percentage); cy.getByTestId('close-drawer').click(); diff --git a/frontend/cypress/support/commands.ts b/frontend/cypress/support/commands.ts index 8ae4fa1522..e83e04410b 100644 --- a/frontend/cypress/support/commands.ts +++ b/frontend/cypress/support/commands.ts @@ -49,7 +49,6 @@ Cypress.Commands.add( (currentValue: number, shouldChangeConfidence: boolean, changeInfo: string | null, initiatives: string | null) => { cy.getByTestId('check-in-metric-value').clear().type(currentValue.toString()); changeConfidence(shouldChangeConfidence); - cy.getByTestId('check-in-next').click(); if (changeInfo) { cy.getByTestId('changeInfo').clear().type(changeInfo!); } @@ -83,7 +82,6 @@ Cypress.Commands.add( break; } changeConfidence(shouldChangeConfidence); - cy.getByTestId('check-in-next').click(); if (changeInfo) { cy.getByTestId('changeInfo').clear().type(changeInfo!); } diff --git a/frontend/src/app/app.module.ts b/frontend/src/app/app.module.ts index 7a6b98b188..0ac15b4dd3 100644 --- a/frontend/src/app/app.module.ts +++ b/frontend/src/app/app.module.ts @@ -50,7 +50,6 @@ import { MatCheckboxModule } from '@angular/material/checkbox'; import { CheckInFormMetricComponent } from './shared/dialog/checkin/check-in-form-metric/check-in-form-metric.component'; import { UnitValueTransformationPipe } from './shared/pipes/unit-value-transformation/unit-value-transformation.pipe'; import { CheckInFormOrdinalComponent } from './shared/dialog/checkin/check-in-form-ordinal/check-in-form-ordinal.component'; -import { CheckInBaseInformationsComponent } from './shared/dialog/checkin/check-in-base-informations/check-in-base-informations.component'; import { CustomInputComponent } from './shared/custom/custom-input/custom-input.component'; import { ConfirmDialogComponent } from './shared/dialog/confirm-dialog/confirm-dialog.component'; import { CheckInFormComponent } from './shared/dialog/checkin/check-in-form/check-in-form.component'; @@ -121,7 +120,6 @@ export const MY_FORMATS = { CheckInFormMetricComponent, UnitValueTransformationPipe, CheckInFormOrdinalComponent, - CheckInBaseInformationsComponent, CustomInputComponent, CheckInFormComponent, UnitLabelTransformationPipe, diff --git a/frontend/src/app/confidence/confidence.component.html b/frontend/src/app/confidence/confidence.component.html index b257a273bd..53a8596cbb 100644 --- a/frontend/src/app/confidence/confidence.component.html +++ b/frontend/src/app/confidence/confidence.component.html @@ -1,4 +1,8 @@ -
{{ checkIn.confidence }}/{{ max }}
diff --git a/frontend/src/app/confidence/confidence.component.scss b/frontend/src/app/confidence/confidence.component.scss
index 3c29f34756..04762dddbc 100644
--- a/frontend/src/app/confidence/confidence.component.scss
+++ b/frontend/src/app/confidence/confidence.component.scss
@@ -14,7 +14,8 @@ p {
}
mat-slider {
- min-width: 350px;
+ width: 100%;
+ max-width: 350px;
}
.bg-light-gray {
diff --git a/frontend/src/app/keyresult-detail/keyresult-detail.component.html b/frontend/src/app/keyresult-detail/keyresult-detail.component.html
index 76e39fbbea..5bf14a866c 100644
--- a/frontend/src/app/keyresult-detail/keyresult-detail.component.html
+++ b/frontend/src/app/keyresult-detail/keyresult-detail.component.html
@@ -24,11 +24,7 @@
Confidence
-