Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ptime mapper script #737

Draft
wants to merge 80 commits into
base: master
Choose a base branch
from
Draft

Ptime mapper script #737

wants to merge 80 commits into from

Conversation

RandomTannenbaum
Copy link
Collaborator

No description provided.

@ManuelMoeri ManuelMoeri linked an issue Jun 24, 2024 that may be closed by this pull request
Write ID Mapper-Script | PuzzleTime Sync #2 #735
Open
4 tasks
ManuelMoeri and others added 27 commits June 24, 2024 14:18
@ManuelMoeri
Implement basic PTime client class and install webmock gem
2f1660f
@ManuelMoeri
Create new migration to fix naming of ptime_emplyoee_id attribute
0555ec7
@ManuelMoeri
Add first test to see how webmock works
83fa511
@RandomTannenbaum
Fix first client spec
fbc8987
@RandomTannenbaum
Write json body to test employee endpoint
6a75e33
@RandomTannenbaum
Fix tests by allowing localhost connection and write negative test fo…
6a9a89a 
…r the ptime client
@RandomTannenbaum
Make ptime client specs not read values from env variables
9ddd723
@RandomTannenbaum
Set error messages on errors in client and change test data urls to e…
7ab6727 
…xample.com
@RandomTannenbaum
Fix params of ptime client and implement basic mapper script
8f85e91
@RandomTannenbaum
Add new tests and remove unnecessary
f945378
@ManuelMoeri
Add test for ambiguous matched people
933c2fc
@ManuelMoeri
Add email to filter before matching as well
ff37bcc
@ManuelMoeri
Possibly make rubocop happy
244369f
@ManuelMoeri
Try to make rubocop happy again
7e58084
@RandomTannenbaum
Add evaluate task for mapping script
132424a
@RandomTannenbaum
Outsource mapper script code to methods and fix tests
2070ffb
@RandomTannenbaum
Add test for dry run
b89c933
@RandomTannenbaum
Make rubocop happy :)
b44a2d0
@RandomTannenbaum
Remove unnecessary requires
f9be66c
@RandomTannenbaum
Replace .count == 1 with .one?
104185e
@RandomTannenbaum
Start writing script that updates the data of the people in skills
aa4c5f5
@RandomTannenbaum
Write script that maps the data from a ptime employee to the correspo…
7d775c3 
…nding skills person
@RandomTannenbaum
Disable rubocop metrics all together instead of one by one in assign …
82d03f0 
…employee id and update people data scripts
@RandomTannenbaum
Fix file naming of spec files
96913d2
@RandomTannenbaum
Move class into module and fix mapping of person to employee data, wr…
907da90 
…ite specs to test mapping of people data
@RandomTannenbaum
Fix updating of people data and test it and fix faulty key in json us…
35f4b0d 
…ed for testing requests
@RandomTannenbaum
Fix update people data specs by assigning the ptime base url env var …
1190569 
…in before each
ManuelMoeri and others added 25 commits July 17, 2024 16:32
@ManuelMoeri
Fix last test and remove pry
456f27b
@ManuelMoeri
Fix test and add comment
4718e92
@ManuelMoeri
Generalize window resizing of capybara
bf771aa
@ManuelMoeri
Cleanup code and add comments
189ab80
@ManuelMoeri
Add one more test for client.rb
2e2ae6b
@ManuelMoeri
Reverse test from last commit
766e942
@kcinay055679
change location of helper
aa36e82
@kcinay055679
set ptime stubing global
4153a5b
@kcinay055679
clean up ptime client specs
87d84d8
@kcinay055679
create json file for fixtures
96391b2
@kcinay055679
use hashes instead of strings for json keys create global ptime stub …
cce291b 
…method
@kcinay055679
use custom ptime stubbing method everywhere
d3bb9c3
@kcinay055679
fix tests after always using [:data]
dd96900
@kcinay055679
clean up ptime client
0d1c4ff
@kcinay055679
improve structure of people search
7550234
@kcinay055679
Client isn't longer controlled by random env vars
552cf7d
@kcinay055679
simplify ptime_helpers
d9c02be
@kcinay055679
clean up PR
44d76bd
@kcinay055679
Clean up Skills db fallback logic
71db98a
@kcinay055679
improve readability by using more helper
3a7997a
@kcinay055679
clean up
d19bd8e
@kcinay055679
add client test
57ad58a
@kcinay055679
Merge pull request #748 from puzzle/feature/745-fetch-people-search-e…
5411381 
…ntries-from-ptime

feature/745 fetch people search entries from ptime
@kcinay055679
ds muäs so
af3def7
@kcinay055679
so its aber
2763d61
@kcinay055679 kcinay055679 force-pushed the ptime-mapper-script branch from a2d0349 to 2763d61 Compare July 29, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robin481 Robin481 Robin481 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Robin481 Robin481

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write ID Mapper-Script | PuzzleTime Sync #2 Create delayed job | PuzzleTime Sync #3
5 participants
@RandomTannenbaum @Robin481 @mtnstar @ManuelMoeri @kcinay055679