Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router / Extension - Remove or increase header size limit #106

Open
1 of 8 tasks
huntharo opened this issue Jan 24, 2024 · 0 comments
Open
1 of 8 tasks

Router / Extension - Remove or increase header size limit #106

huntharo opened this issue Jan 24, 2024 · 0 comments
Assignees
Labels
area-extension Extension portion of the app area-router Router portion of the app enhancement New feature or request

Comments

@huntharo
Copy link
Contributor

huntharo commented Jan 24, 2024

Motivations

  • Currently there is a hard limit on the size of headers that are parsed
  • The limit is bad as it will break requests in an undefined way

Acceptance Criteria

  • Consider removing the limit completely or making it configurable
  • Add tests to see what happens when there are more headers than the limit allows
    • Extension
    • Router

Notes on Approach for the Router

  • Function to be tested:
  • Currently there are no LambdaConnection.cs direct tests (tested indirectly via other files)
  • Cases to implement:
    • Send the header on the response to the extension (which contains the HTTP request for the extension to run) and validate that it arrives at the contained app with the correct and complete context
    • Send the header on the simulated response from the extension and confirm that it is passed through the router back to the incoming request into the router
    • 4 x 31 KB headers:
      async fn test_lambda_service_valid_124kb_of_headers() {
    • 1 x 64 KB header:
      async fn test_lambda_service_valid_oversized_headers() {
@huntharo huntharo self-assigned this Jan 24, 2024
@huntharo huntharo added the enhancement New feature or request label Mar 30, 2024
@huntharo huntharo added area-extension Extension portion of the app area-router Router portion of the app labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-extension Extension portion of the app area-router Router portion of the app enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant