-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement uncompress functionality for PDF files #75
Conversation
@Lucas-C i have made all the changes. There is currently one linting issue though, with All Linting tests gets passed when i run them locally or through GitHub codespaces but black fails in the workflow. |
output: Annotated[ | ||
Path, | ||
typer.Argument( | ||
exists=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exists=False, |
It can be really useful to override an existing file, I'm not sure this check is needed.
We alread removed it from other subcommands.
exists=True, | ||
file_okay=True, | ||
dir_okay=False, | ||
writable=False, | ||
readable=True, | ||
resolve_path=True, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exists=True, | |
file_okay=True, | |
dir_okay=False, | |
writable=False, | |
readable=True, | |
resolve_path=True, | |
dir_okay=False, | |
exists=True, | |
resolve_path=True, |
Removing the parameters provided that are identical to the default values: https://github.com/fastapi/typer/blob/master/typer/params.py#L301
I added a couple of commits to please both I also approved this PR: good job! 👍 I made 2 final suggestions because I recently harmonized Thank you very much for your contribution @Kaos599 👍 👍 👍 |
## What's new ### New Features (ENH) - New `booklet` command to adjust offsets and lengths ([PR #77](#77)) - New `uncompress` command ([PR #75](#75)) - New `update-offsets` command to adjust offsets and lengths ([PR #15](#15)) - New `rm` command ([PR #59](#59)) - `metadata`: now also displaying CreationDate, Creator, Keywords & Subject ([PR #73](#73)) - Add warning for out-of-bounds page range in pdfly `cat` command ([PR #58](#58)) ### Bug Fixes (BUG) - `2-up` command, that only showed one page per sheet, on the left side, with blank space on the right ([PR #78](#78)) [Full Changelog](0.3.3...0.4.0)
This has been released in version |
Closes #38
uncompress.py
script to decompress Flate-encoded content streams in PDF files.Uncompress
function toREADME.md
.tests\test_uncompress.py
pyproject.toml
to include the I001 rule for Ruff linter to ignore specific linting issues, since it was conflicting with black