Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Removing context initially where I can #156

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

adam2392
Copy link
Collaborator

Related to #112

Changes proposed in this pull request:

  • This removes the user-facing "Context" object. It is very hard to develop on top of right now, and there is no clearly defined API usage with the context yet.
  • In the future, we can merge back in the Context to consolidate the API, but rn it hinders development

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.
  • I have added a changelog entry succintly describing the change in this PR in the whats_new relevant version document.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

@adam2392 adam2392 merged commit 5564b7c into py-why:main Jul 18, 2024
25 of 26 checks passed
@adam2392 adam2392 deleted the privcontext branch July 18, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant