-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor steps in blending code #440
Comments
I have started with the rough outlines of the code but will work on it later this week. |
@mats-knmi I have a question regarding the ndim=4 check you did to determine if the forecast provided has been decomposed already or not. I see a lot of potential for problems here. Let me try and list my assumptions and downsides below, I would love to hear your thoughts on possible solutions:
|
I didn't create this check, it was already in the original code, I just moved it around. There is a line in the docstring telling users to add a dimension in the case you describe. I do agree that this is less then ideal. In my opinion the ideal solution would involve xarray, because in the case of an xarray dataset all dimensions would be named and thus you wouldn't have to assume anything based on the number of dimensions. You could do something like The xarray conversion I have been working on has been on hold for a bit, since I have been busy with other things, but the nowcasting code had already been entirely converted to xarray and I have merged your refactored code in there. |
Issue #395 should be done for the blending code aswel.
The text was updated successfully, but these errors were encountered: