Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two tests for eliding_label fail at high resolution screens #38

Open
MosGeo opened this issue Nov 5, 2021 · 1 comment
Open

Two tests for eliding_label fail at high resolution screens #38

MosGeo opened this issue Nov 5, 2021 · 1 comment
Labels
tests related to tests or CI

Comments

@MosGeo
Copy link
Contributor

MosGeo commented Nov 5, 2021 •
edited
Loading

Describe the bug
I am noting that two tests in the eliding_label fails at my laptop. I believe it is related to the fact I am using high resolution screen with some scaling similar to #26

To Reproduce
Steps to reproduce the behavior:

  1. Test test_eliding_label.py at high resolution laptop

Expected behavior
Test pass

Screenshots
image

Desktop (please complete the following information):

  • OS with version: Windows 10 64bit
  • Qt Backend: PySide2
  • Python version: Python 3.8.10 64bit
  • Environment is setup using the development requirements listed in the repository
@tlambert03
Copy link
Member

Thanks, yeah those are definitely flaky tests. Need to come up with a better way to know expectations. I suspect we can use pixel metrics and stuff, but it was a lot of work just to make sure that we were roughly eliding.

Thanks for letting me know, needs fixing

@tlambert03 tlambert03 added the tests related to tests or CI label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests related to tests or CI
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tlambert03 @MosGeo