Add tests for issue #5020: silent conversion to float #5025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enums (including enum class) are silently converted to floats during method calls. This can cause overload resolution to fail. I believe this behavior is a bug. This commit adds tests for that behavior. These tests fail right now, but they should pass once the behavior is fixed. See: pybind#5020
|
Are you looking for help fixing this? (I believe it is very unlikely that any of the current maintainers will pick this up. But if you or someone else steps up, I could try to help with hints.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created some tests for the behavior described in #5020: enum should not be silently converted to float during method call
Description
The most relevant issue is #5020. This is behavior that was noticed during real-world testing. Libraries for numerical analysis often include large sets of functions, with enums as parameters that can control the selected algorithm or method.
In this instance, a function that took several double parameters at the end was erroneously called, instead of one taking an enum.
I've added tests for this behavior with
float, where I believe it should probably be fixed for all enums, however if it would at all be possible to disable this behavior (and prevent an enum from being silently cast to a numeric value of any kind), that would be ideal.Suggested changelog entry:
No entry is needed until this is fixed