Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor optimiser interface to parameter sensitivity analysis #668

Open
BradyPlanden opened this issue Feb 11, 2025 · 0 comments
Open

Refactor optimiser interface to parameter sensitivity analysis #668

BradyPlanden opened this issue Feb 11, 2025 · 0 comments

Comments

@BradyPlanden
Copy link
Member

Currently the parameter sensitivity analysis is a method with the cost class and is called by the optimiser class during the _run() method. This allows the following:

  • A user can add sensitivity analysis to an optimisation task by passing the `compute_sensitivities' argument to the optimiser on construction.
  • The sensitivities will be printed to the user within the OptimisationResult output.

However, the interface to the optimiser via the args compute_sensitivities and n_sensitivity_samples is rather clumsy, and could be cleaned up for clearer usage. I suggest we do the following:

  • Clean up the optimiser call compute_sensitivities to accept a tuple of format (Bool, Int) corresponding to whether the sensitivities are computed and the number of samples used. At the same time, depreciate the argument n_sensitivities_sample.
  • Move the sensitivity calculation inside the OptimisationResult class to avoid mixing the calculation between the two.

Other thoughts are welcome, the main functionality I'd like to keep is the sensitivities stored and displayed by the OptimisationResult class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant