Question regarding the implementation of the bluetooth driver on technic hub

[NStrijbosch]

I am exploring the possibility to connect a LEGO Mario to a Technic Hub running pybricks.

At this point I have established a stable connection!
But to achieve this I had to comment out a small piece of code:

https://github.com/pybricks/pybricks-micropython/blob/master/lib/pbio/drv/bluetooth/bluetooth_stm32_cc2640.c#:~:text=//%20Assuming%20that%20we,%7D)%3B

I do not understand the purpose of these few lines, and I am just wondering what the impact of removing these lines might be.
Moreover, any ideas why these lines are blocking the connection process of the Mario but are not blocking when connecting the Remote or City hub?

[dlech]

The link just shows the entire file. It might be easier to just push your changes to GitHub so we can see what you changed.

[NStrijbosch]

wireshark_connect_mario.csv

Attached some logs of the bluetooth communication using wireshark while connecting to Mario.

[dlech]

Great. I'm guessing Mario must not properly implement the command that GATT_DiscCharsByUUID() sends. This command is supposed to find the handle number for the LWP3 Hub characteristic. When connecting from the computer, it enumerates all characteristics instead of a specific one, so it uses a different command. As a hack we could try adding remote_lwp3_char_handle = 0x0011; in place of the code you commented out.

[NStrijbosch]

Yes, great.That did the trick!
Thanks for your quick response

[dlech]

FYI, I just pushed a couple more commits that you might find interesting.

[NStrijbosch]

Great! I was already expecting the last one ;)