Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: isolating pmdarima soft dependency #4127

Open
fkiraly opened this issue Feb 9, 2025 · 0 comments · May be fixed by #4129
Open

[ENH]: isolating pmdarima soft dependency #4127

fkiraly opened this issue Feb 9, 2025 · 0 comments · May be fixed by #4129
Labels
enhancement New feature or request

Comments

@fkiraly
Copy link

fkiraly commented Feb 9, 2025

Describe the feature you want to add to this project

pmdarima is blocking 3.13 compatibility, but is imported only in two places for ndiffs, nsdiffs.

Describe your proposed solution

I suggest to isolate the soft dependency in the code base.

I think the two imports could be moved inside the functions. We should then run tests to see what happens.

After that, we could remove it from the core dep set.

Perhaps a deprecation period is in order, i.e., isolate and then have any call to the function produce a warning, that this feature will require the timeseries dep set from next MINOR.

Describe alternatives you've considered, if relevant

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant