MAINT - Update pre-commit hooks and config #2044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
tag: dependencies
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Carreau
reviewed
Nov 20, 2024
Carreau
previously approved these changes
Nov 20, 2024
trallard
force-pushed
the
trallard/update-pre-commit-hooks
branch
from
8e10365
to
04ebf7b
Compare
drammock
previously approved these changes
Nov 20, 2024
| @@ -68,3 +65,9 @@ repos: | |||
| # stylelint itself needs to be here when using additional_dependencies. | |||
| - [email protected] | |||
There was a problem hiding this comment.
odd that this version (16.5.0) doesn't match rev: v16.10.0 above
Co-authored-by: Daniel McCloy <[email protected]>
|
I think this PR and #2045 have diverged; which one is the cannonical one ? |
|
Will open a fresh one @Carreau |
|
Got it! Opened a new follow-up PR #2049 so these two should be now ready to merge I believe |
|
I'm going to likely merge #2049 directly as this would need to get the logging fix into it as well. I'm going to move to draft to avoid extra reviews. |
Carreau
added a commit
that referenced
this pull request
Nov 21, 2024
Follows-up #2044 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Daniel McCloy <[email protected]> Co-authored-by: M Bussonnier <[email protected]>
|
Closing as #2049 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on another PR, I noticed some additions that would be beneficial here, so I decided to clean our pre-commit hooks and configuration.
So that you know, I will open a separate follow-up PR with the actual fixes to make the review easier.
Notable items:
ruff, it did not make sense to haveblackseparately as ruff is compatible withblackprettierhookCloses #1880
Closes #2047