fix: PATH update for non-fish shells #474
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reloading my shell config leads to duplication of path segments related to
pyenv-virtualenv
because the command:which is part of my config, as per the README, is run without any checks of the current
PATH
being done in the background.I've been experiencing this problem for many years but never had the time to look into it until now. Was surprised to not find any issues pointing out this problem, especially since the code has been around (unchanged) for so long, but found PR #430, in which another user fixed this problem for the fish shell a couple of years ago.
My PR looks to do the same for the catch-all
case
statement which follows the fish shell check. I'm not familiar with the code construct the other user used, so went with a statement that works for me in my zsh config. I'll note that I didn't test this in shells other than zsh, and also don't know enough about other shells and how they deal with bash scripts to be able to tell if this could not work in others.